Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Unified Diff: chrome/browser/extensions/extension_tabs_module.cc

Issue 7661009: base: Add Is* functions to Value class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: tony review Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_tabs_module.cc
diff --git a/chrome/browser/extensions/extension_tabs_module.cc b/chrome/browser/extensions/extension_tabs_module.cc
index a949b4df1de9d75d041314d9248999ed25cfe9b4..04ab3cc42924798a266386f16e329ac93ef7afaa 100644
--- a/chrome/browser/extensions/extension_tabs_module.cc
+++ b/chrome/browser/extensions/extension_tabs_module.cc
@@ -413,11 +413,11 @@ bool CreateWindowFunction::RunImpl() {
args->Get(keys::kUrlKey, &url_value);
// First, get all the URLs the client wants to open.
- if (url_value->IsType(Value::TYPE_STRING)) {
+ if (url_value->IsString()) {
std::string url_string;
url_value->GetAsString(&url_string);
url_strings.push_back(url_string);
- } else if (url_value->IsType(Value::TYPE_LIST)) {
+ } else if (url_value->IsList()) {
const ListValue* url_list = static_cast<const ListValue*>(url_value);
for (size_t i = 0; i < url_list->GetSize(); ++i) {
std::string url_string;
« no previous file with comments | « chrome/browser/extensions/extension_settings_api.cc ('k') | chrome/browser/extensions/extension_webrequest_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698