Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Issue 766053006: Add a new role for an iframe element with role=presentation. (Closed)

Created:
6 years ago by dmazzoni
Modified:
6 years ago
Reviewers:
aboxhall
CC:
blink-reviews, dglazkov+blink, Dan Beam
Project:
blink
Visibility:
Public.

Description

Add a new role for an iframe element with role=presentation. See bug for context; we'd like to make it possible for an author to set role=presentation on an iframe to make the iframe seamlessly blend into the AX tree. BUG=436186 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186495

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M Source/modules/accessibility/AXObject.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/accessibility/AXRenderObject.cpp View 1 1 chunk +5 lines, -1 line 0 comments Download
M Source/web/AssertMatchingEnums.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M public/web/WebAXEnums.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
dmazzoni
6 years ago (2014-12-01 20:03:39 UTC) #2
aboxhall
lgtm
6 years ago (2014-12-02 16:44:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/766053006/1
6 years ago (2014-12-02 16:55:01 UTC) #5
commit-bot: I haz the power
Failed to apply patch for Source/modules/accessibility/AXObject.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years ago (2014-12-02 16:55:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/766053006/20001
6 years ago (2014-12-04 09:13:09 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-04 10:27:04 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186495

Powered by Google App Engine
This is Rietveld 408576698