Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1036)

Unified Diff: Source/modules/accessibility/AXRenderObject.cpp

Issue 766053006: Add a new role for an iframe element with role=presentation. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/accessibility/AXObject.h ('k') | Source/web/AssertMatchingEnums.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/accessibility/AXRenderObject.cpp
diff --git a/Source/modules/accessibility/AXRenderObject.cpp b/Source/modules/accessibility/AXRenderObject.cpp
index 91486f739aed8dbb5dd1c3558dc45cf47de2acb6..dad5bff6c5d340eb100d5258322fc909b5d6ecb4 100644
--- a/Source/modules/accessibility/AXRenderObject.cpp
+++ b/Source/modules/accessibility/AXRenderObject.cpp
@@ -427,8 +427,12 @@ AccessibilityRole AXRenderObject::determineAccessibilityRole()
if (isHTMLHtmlElement(node))
return IgnoredRole;
- if (node && node->hasTagName(iframeTag))
+ if (node && node->hasTagName(iframeTag)) {
+ const AtomicString& ariaRole = getAttribute(roleAttr);
+ if (ariaRole == "none" || ariaRole == "presentation")
+ return IframePresentationalRole;
return IframeRole;
+ }
if (isEmbeddedObject())
return EmbeddedObjectRole;
« no previous file with comments | « Source/modules/accessibility/AXObject.h ('k') | Source/web/AssertMatchingEnums.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698