Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 76583002: Add no_auth flag to skip auth checking for buckets that don't require it. Also fix tests (Closed)

Created:
7 years, 1 month ago by hinoka
Modified:
7 years, 1 month ago
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Add no_auth flag to skip auth checking for buckets that don't require it. Also fix tests BUG=321254 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=236039

Patch Set 1 #

Total comments: 3

Patch Set 2 : Make it so that --no_auth also sets the boto file to os.devnull #

Patch Set 3 : Set the boto file to empty if --no_auth is specified #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -4 lines) Patch
M download_from_google_storage.py View 1 2 3 chunks +13 lines, -2 lines 0 comments Download
M tests/download_from_google_storage_unittests.py View 1 4 chunks +19 lines, -1 line 0 comments Download
M tests/upload_to_google_storage_unittests.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Ryan Tseng
7 years, 1 month ago (2013-11-19 19:28:33 UTC) #1
ghost stip (do not use)
lgtm https://codereview.chromium.org/76583002/diff/1/download_from_google_storage.py File download_from_google_storage.py (right): https://codereview.chromium.org/76583002/diff/1/download_from_google_storage.py#newcode301 download_from_google_storage.py:301: help='Skip auth checking. Use if its known that ...
7 years, 1 month ago (2013-11-19 19:32:36 UTC) #2
M-A Ruel
lgtm https://codereview.chromium.org/76583002/diff/1/tests/download_from_google_storage_unittests.py File tests/download_from_google_storage_unittests.py (right): https://codereview.chromium.org/76583002/diff/1/tests/download_from_google_storage_unittests.py#newcode182 tests/download_from_google_storage_unittests.py:182: if not sys.platform.startswith('win'): if sys.platform != 'win32': since ...
7 years, 1 month ago (2013-11-19 19:34:40 UTC) #3
Ryan Tseng
PTAL again - Pointing the boto file to nothing should be a more better way ...
7 years, 1 month ago (2013-11-19 20:16:32 UTC) #4
M-A Ruel
lgtm
7 years, 1 month ago (2013-11-19 20:18:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hinoka@chromium.org/76583002/80002
7 years, 1 month ago (2013-11-19 20:23:28 UTC) #6
commit-bot: I haz the power
7 years, 1 month ago (2013-11-19 20:25:23 UTC) #7
Message was sent while issue was closed.
Change committed as 236039

Powered by Google App Engine
This is Rietveld 408576698