Add no_auth flag to skip auth checking for buckets that don't require it. Also fix tests

download_from_google_storage.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Download files from Google Storage based on SHA1 sums."""
 
 
 import hashlib
 import optparse
@@ skipping 27 matching lines @@
   and is also immutable."""
   def __init__(self, path, boto_path, timeout=None):
     if not os.path.exists(path):
       raise FileNotFoundError('GSUtil not found in %s' % path)
     self.path = path
     self.timeout = timeout
     self.boto_path = boto_path
 
   def get_sub_env(self):
     env = os.environ.copy()
-    if self.boto_path:
+    if self.boto_path == os.devnull:
+      env['AWS_CREDENTIAL_FILE'] = ''
+      env['BOTO_CONFIG'] = ''
+    elif self.boto_path:
       env['AWS_CREDENTIAL_FILE'] = self.boto_path
+      env['BOTO_CONFIG'] = self.boto_path
     else:
       custompath = env.get('AWS_CREDENTIAL_FILE', '~/.boto') + '.depot_tools'
       custompath = os.path.expanduser(custompath)
       if os.path.exists(custompath):
         env['AWS_CREDENTIAL_FILE'] = custompath
 
     return env
 
   def call(self, *args):
     return subprocess2.call((sys.executable, self.path) + args,
@@ skipping 230 matching lines @@
   parser.add_option('-d', '--directory', action='store_true',
                     help='The target is a directory.  '
                          'Cannot be used with -s/--sha1_file.')
   parser.add_option('-s', '--sha1_file', action='store_true',
                     help='The target is a file containing a sha1 sum.  '
                          'Cannot be used with -d/--directory.')
   parser.add_option('-g', '--config', action='store_true',
                     help='Alias for "gsutil config".  Run this if you want '
                          'to initialize your saved Google Storage '
                          'credentials.')
-  parser.add_option('-p', '--platform', 
+  parser.add_option('-n', '--no_auth', action='store_true',
+                    help='Skip auth checking.  Use if it\'s known that the '
+                         'target bucket is a public bucket.')
+  parser.add_option('-p', '--platform',
                     help='A regular expression that is compared against '
                          'Python\'s sys.platform. If this option is specified, '
                          'the download will happen only if there is a match.')
 
   (options, args) = parser.parse_args()
 
   # Make sure we should run at all based on platform matching.
   if options.platform:
     if not re.match(options.platform, sys.platform):
       print('The current platform doesn\'t match "%s", skipping.' %
             options.platform)
       return 0
 
+  # Set the boto file to /dev/null if we don't need auth.
+  if options.no_auth:
+    options.boto = os.devnull
+
   # Make sure we can find a working instance of gsutil.
   if os.path.exists(GSUTIL_DEFAULT_PATH):
     gsutil = Gsutil(GSUTIL_DEFAULT_PATH, boto_path=options.boto)
   else:
     gsutil = None
     for path in os.environ["PATH"].split(os.pathsep):
       if os.path.exists(path) and 'gsutil' in os.listdir(path):
         gsutil = Gsutil(os.path.join(path, 'gsutil'), boto_path=options.boto)
     if not gsutil:
       parser.error('gsutil not found in %s, bad depot_tools checkout?' %
@@ skipping 46 matching lines @@
     return code
 
   return download_from_google_storage(
       input_filename, base_url, gsutil, options.num_threads, options.directory,
       options.recursive, options.force, options.output, options.ignore_errors,
       options.sha1_file)
 
 
 if __name__ == '__main__':
   sys.exit(main(sys.argv))