Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 765753003: Move window_manager service implementation to //services (Closed)

Created:
6 years ago by jamesr
Modified:
6 years ago
Reviewers:
Elliot Glaysher
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, esprehn, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -3209 lines) Patch
M examples/window_manager/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/window_manager/window_manager.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M examples/wm_flow/BUILD.gn View 3 chunks +3 lines, -3 lines 0 comments Download
M examples/wm_flow/wm/frame_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M examples/wm_flow/wm/frame_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/wm_flow/wm/wm.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D mojo/services/window_manager/BUILD.gn View 1 chunk +0 lines, -101 lines 0 comments Download
D mojo/services/window_manager/DEPS View 1 chunk +0 lines, -15 lines 0 comments Download
D mojo/services/window_manager/basic_focus_rules.h View 1 chunk +0 lines, -45 lines 0 comments Download
D mojo/services/window_manager/basic_focus_rules.cc View 1 chunk +0 lines, -62 lines 0 comments Download
D mojo/services/window_manager/focus_controller.h View 1 chunk +0 lines, -104 lines 0 comments Download
D mojo/services/window_manager/focus_controller.cc View 1 chunk +0 lines, -320 lines 0 comments Download
D mojo/services/window_manager/focus_controller_observer.h View 1 chunk +0 lines, -36 lines 0 comments Download
D mojo/services/window_manager/focus_controller_unittest.cc View 1 chunk +0 lines, -449 lines 0 comments Download
D mojo/services/window_manager/focus_rules.h View 1 chunk +0 lines, -62 lines 0 comments Download
D mojo/services/window_manager/main.cc View 1 chunk +0 lines, -76 lines 0 comments Download
D mojo/services/window_manager/native_viewport_event_dispatcher_impl.h View 1 chunk +0 lines, -38 lines 0 comments Download
D mojo/services/window_manager/native_viewport_event_dispatcher_impl.cc View 1 chunk +0 lines, -35 lines 0 comments Download
D mojo/services/window_manager/view_event_dispatcher.h View 1 chunk +0 lines, -47 lines 0 comments Download
D mojo/services/window_manager/view_event_dispatcher.cc View 1 chunk +0 lines, -58 lines 0 comments Download
D mojo/services/window_manager/view_target.h View 1 chunk +0 lines, -97 lines 0 comments Download
D mojo/services/window_manager/view_target.cc View 1 chunk +0 lines, -167 lines 0 comments Download
D mojo/services/window_manager/view_target_unittest.cc View 1 chunk +0 lines, -81 lines 0 comments Download
D mojo/services/window_manager/view_targeter.h View 1 chunk +0 lines, -44 lines 0 comments Download
D mojo/services/window_manager/view_targeter.cc View 1 chunk +0 lines, -97 lines 0 comments Download
D mojo/services/window_manager/view_targeter_unittest.cc View 1 chunk +0 lines, -106 lines 0 comments Download
D mojo/services/window_manager/window_manager_api_unittest.cc View 1 chunk +0 lines, -264 lines 0 comments Download
D mojo/services/window_manager/window_manager_app.h View 1 chunk +0 lines, -181 lines 0 comments Download
D mojo/services/window_manager/window_manager_app.cc View 1 chunk +0 lines, -340 lines 0 comments Download
D mojo/services/window_manager/window_manager_delegate.h View 1 chunk +0 lines, -25 lines 0 comments Download
D mojo/services/window_manager/window_manager_impl.h View 1 chunk +0 lines, -65 lines 0 comments Download
D mojo/services/window_manager/window_manager_impl.cc View 1 chunk +0 lines, -81 lines 0 comments Download
D mojo/services/window_manager/window_manager_test_util.h View 1 chunk +0 lines, -38 lines 0 comments Download
D mojo/services/window_manager/window_manager_test_util.cc View 1 chunk +0 lines, -29 lines 0 comments Download
D mojo/services/window_manager/window_manager_unittests.cc View 1 chunk +0 lines, -43 lines 0 comments Download
M services/BUILD.gn View 2 chunks +8 lines, -0 lines 0 comments Download
A + services/window_manager/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + services/window_manager/basic_focus_rules.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + services/window_manager/basic_focus_rules.cc View 1 chunk +1 line, -1 line 0 comments Download
A + services/window_manager/focus_controller.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + services/window_manager/focus_controller.cc View 1 chunk +5 lines, -5 lines 0 comments Download
A + services/window_manager/focus_controller_observer.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + services/window_manager/focus_controller_unittest.cc View 1 chunk +6 lines, -6 lines 0 comments Download
A + services/window_manager/focus_rules.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + services/window_manager/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + services/window_manager/native_viewport_event_dispatcher_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + services/window_manager/native_viewport_event_dispatcher_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + services/window_manager/view_event_dispatcher.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + services/window_manager/view_event_dispatcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + services/window_manager/view_target.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + services/window_manager/view_target.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + services/window_manager/view_target_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + services/window_manager/view_targeter.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + services/window_manager/view_targeter.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + services/window_manager/view_targeter_unittest.cc View 1 chunk +5 lines, -5 lines 0 comments Download
A + services/window_manager/window_manager_api_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + services/window_manager/window_manager_app.h View 3 chunks +7 lines, -7 lines 0 comments Download
A + services/window_manager/window_manager_app.cc View 2 chunks +7 lines, -7 lines 0 comments Download
A + services/window_manager/window_manager_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + services/window_manager/window_manager_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + services/window_manager/window_manager_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + services/window_manager/window_manager_test_util.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + services/window_manager/window_manager_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
A + services/window_manager/window_manager_unittests.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M sky/tools/debugger/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M sky/tools/debugger/debugger.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tools/debugger/debugger.cc View 1 chunk +1 line, -1 line 0 comments Download
M sky/tools/tester/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M sky/tools/tester/tester.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jamesr
Elliot - I'm not sure if this'll be disruptive with your de-aurification work. If so, ...
6 years ago (2014-12-02 02:13:55 UTC) #1
Elliot Glaysher
it'll be a little disruptive, but I don't think that's a good reason to not ...
6 years ago (2014-12-02 18:23:29 UTC) #2
jamesr
6 years ago (2014-12-02 18:52:07 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
1581cd6f7941565ab556842d05c5dbcf884490f5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698