LayoutTests/fast/canvas/canvas-hit-regions-fill-rule-test.html - Issue 765673005: IDL: Null values should be converted for non-nullable dictionary members

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/canvas/canvas-hit-regions-fill-rule-test.html

Issue 765673005: IDL: Null values should be converted for non-nullable dictionary members (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/canvas/canvas-hit-regions-basic-test.html ('k') | LayoutTests/fast/dom/idl-dictionary-unittest.html » ('j') | Source/bindings/templates/dictionary_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/canvas/canvas-hit-regions-fill-rule-test.html

diff --git a/LayoutTests/fast/canvas/canvas-hit-regions-fill-rule-test.html b/LayoutTests/fast/canvas/canvas-hit-regions-fill-rule-test.html

index 5bdbe3cefd829c92a2ee17d099eabca1a6da0be4..7775b6c803c535bc551e640fbefc74010efd4d11 100644

--- a/LayoutTests/fast/canvas/canvas-hit-regions-fill-rule-test.html

+++ b/LayoutTests/fast/canvas/canvas-hit-regions-fill-rule-test.html

@@ -77,6 +77,7 @@

context.removeHitRegion("nonzero");

+ // FIXME: This test fails. ToString(null) becomes "null", and "null" is not a valid enum value of fillRule.

context.addHitRegion({

id : "nonzero",

fillRule : null