Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: LayoutTests/fast/canvas/canvas-hit-regions-basic-test.html

Issue 765673005: IDL: Null values should be converted for non-nullable dictionary members (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/canvas/canvas-hit-regions-basic-test.html
diff --git a/LayoutTests/fast/canvas/canvas-hit-regions-basic-test.html b/LayoutTests/fast/canvas/canvas-hit-regions-basic-test.html
index 4d8179ed4d3091345ec58743d56b5aaf4449e954..dbae6b990b691fdfd83d6b34c394ecd79f83aee4 100644
--- a/LayoutTests/fast/canvas/canvas-hit-regions-basic-test.html
+++ b/LayoutTests/fast/canvas/canvas-hit-regions-basic-test.html
@@ -77,6 +77,8 @@
debug("NotSupportedError exception tests");
shouldThrow("context.addHitRegion()");
shouldThrow("context.addHitRegion({ id : '' })");
+ // This test fails. ToString(null) becomes "null", and it seems that "null" is a valid value for id.
+ // (e.g. <div id="null"></div>)
shouldThrow("context.addHitRegion({ id : null })");
shouldThrow("context.addHitRegion({ id : undefined })");
shouldThrow("context.addHitRegion({ control : {} })");

Powered by Google App Engine
This is Rietveld 408576698