Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 765643004: remove unused device::eraseColor (Closed)

Created:
6 years ago by reed1
Modified:
6 years ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

remove unused device::eraseColor BUG=skia: TBR= Committed: https://skia.googlesource.com/skia/+/b1ab276c3719d6690e58f347c25126d2b8929c5d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M include/core/SkDevice.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/765643004/1
6 years ago (2014-12-03 16:32:30 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years ago (2014-12-03 16:32:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/765643004/1
6 years ago (2014-12-03 17:47:41 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/b1ab276c3719d6690e58f347c25126d2b8929c5d
6 years ago (2014-12-03 17:47:53 UTC) #7
hal.canary
6 years ago (2014-12-03 18:40:31 UTC) #8
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/777003002/ by halcanary@google.com.

The reason for reverting is:
../../skia/ext/bitmap_platform_device_cairo.cc:131:13: error: no member named
'eraseColor' in 'skia::BitmapPlatformDevice'
.

Powered by Google App Engine
This is Rietveld 408576698