Issue 765223002: Ignore PNG gamma chunk when PNG images have a color profile

Issue 765223002: Ignore PNG gamma chunk when PNG images have a color profile (Closed)

Created:
6 years ago by Noel Gordon

Modified:
6 years ago

Reviewers:
tkent

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

Ignore PNG gamma chunk when PNG images have a color profile Per [1], when a PNG has a valid iCCP chunk, the gAMA chunk must be ignored. Do that, and gain compat with Firefox and Safari which do show a green box for the test image. [1] http://www.libpng.org/pub/png/spec/1.2/PNG-Chunks.html Added layout test: fast/images/png-color-profile-ignore-gamma.html BUG=354885 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186210

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -8 lines)			Patch
M	LayoutTests/TestExpectations	View	1 chunk	+3 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/images/png-color-profile-ignore-gamma.html	View	1 chunk	+6 lines, -0 lines	0 comments	Download
A +	LayoutTests/fast/images/png-color-profile-ignore-gamma-expected.txt	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	LayoutTests/fast/images/resources/png-color-profile-and-gamma-chunk.png	View	Binary file		0 comments	Download
M	Source/platform/image-decoders/png/PNGImageDecoder.cpp	View	1 chunk	+12 lines, -9 lines	0 comments	Download

Total messages: 8 (4 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/765223002/40001

6 years ago (2014-12-01 04:26:00 UTC) #7

commit-bot: I haz the power

6 years ago (2014-12-01 04:28:02 UTC) #8

Message was sent while issue was closed.

Committed patchset #1 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186210