chrome/browser/ui/passwords/manage_passwords_bubble_model.h - Issue 765073004: Adding skeleton code for showing Bubble, asking user to submit URL when Password Manager fails

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/manage_passwords_bubble_model.h

Issue 765073004: Adding skeleton code for showing Bubble, asking user to submit URL when Password Manager fails (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/app/generated_resources.grd ('K') | « chrome/browser/password_manager/chrome_password_manager_client.cc ('k') | chrome/browser/ui/passwords/manage_passwords_bubble_model.cc » ('j') | chrome/browser/ui/passwords/manage_passwords_ui_controller.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/passwords/manage_passwords_bubble_model.h

diff --git a/chrome/browser/ui/passwords/manage_passwords_bubble_model.h b/chrome/browser/ui/passwords/manage_passwords_bubble_model.h

index 8674be851ab35b5aaedf2033721a259556aacd82..1ec12ee5c70ff1d99ac89616b22332fc7df3fd11 100644

--- a/chrome/browser/ui/passwords/manage_passwords_bubble_model.h

+++ b/chrome/browser/ui/passwords/manage_passwords_bubble_model.h

@@ -70,6 +70,8 @@ class ManagePasswordsBubbleModel : public content::WebContentsObserver {

// Called by the view code to notify about chosen credential.

void OnChooseCredentials(const autofill::PasswordForm& password_form);

+ GURL origin() const { return origin_; }

password_manager::ui::State state() const { return state_; }

const base::string16& title() const { return title_; }

@@ -111,6 +113,7 @@ class ManagePasswordsBubbleModel : public content::WebContentsObserver {

static int PasswordFieldWidth();

private:

+ GURL origin_;

vabr (Chromium) 2014/12/03 14:08:06 Please clarify (in a comment), origin of what this

melandory 2014/12/04 10:33:46 Done.

password_manager::ui::State state_;

base::string16 title_;

autofill::PasswordForm pending_password_;