Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(697)

Unified Diff: chrome/app/generated_resources.grd

Issue 765073004: Adding skeleton code for showing Bubble, asking user to submit URL when Password Manager fails (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: chrome/app/generated_resources.grd
diff --git a/chrome/app/generated_resources.grd b/chrome/app/generated_resources.grd
index cbb04472279a33846d455ed7cbfa9532629282ae..888e7637437cf046866421ae7b20228ef6bfd862 100644
--- a/chrome/app/generated_resources.grd
+++ b/chrome/app/generated_resources.grd
@@ -7553,6 +7553,9 @@ Keep your key file in a safe place. You will need it to create new versions of y
<message name="IDS_PASSWORD_MANAGER_SAVE_BUTTON" desc="Save button text for password manager">
Save password
</message>
+ <message name="IDS_PASSWORD_MANAGER_SEND_URL_BUTTON" desc="Send URL text for 'Allow to collect URL?' bubble in password manager">
vabr (Chromium) 2014/12/03 14:08:06 nit: It is not clear what a "Send URL text" is. Wh
melandory 2014/12/04 10:33:46 Done.
+ Send URL
+ </message>
<message name="IDS_PASSWORD_MANAGER_UNBLACKLIST_BUTTON" desc="Buton text to re-enable the password manager after blacklisting.">
Undo
</message>
@@ -13266,6 +13269,12 @@ Some features may be unavailable. Please check that the profile exists and you
<message name="IDS_MANAGE_PASSWORDS_CONFIRM_GENERATED_TITLE" desc="The title text that is used in the manage passwords bubble when the user has generated a password.">
Generated password saved
</message>
+ <message name="IDS_MANAGE_PASSWORDS_ASK_TO_SUBMIT_URL_TITLE" desc="The title text that is used in the manage passwords bubble when the password manager failed to detect the form and user is asked if he wants to report the URL">
vabr (Chromium) 2014/12/03 14:08:06 I'd remove "and user is asked if he wants to repor
melandory 2014/12/04 10:33:46 Done.
+ We detected that Chrome password manager failed to handle this URL.
vabr (Chromium) 2014/12/03 14:08:06 "We" is ambiguous. What about: "Chrome password ma
melandory 2014/12/04 10:33:46 Done. sabineb@ said that we should use "Chrome pas
+ </message>
+ <message name="IDS_MANAGE_PASSWORDS_ASK_TO_SUBMIT_URL_TEXT" desc="The text that is used in the manage passwords bubble when the password manager failed to detect the form and user is asked if he wants to report the URL">
vabr (Chromium) 2014/12/03 14:08:06 To clarify the focus (on reporting, not on disclos
melandory 2014/12/04 10:33:46 Done.
+ Do you want to send this URL to Google to improve Chrome?
vabr (Chromium) 2014/12/03 14:08:06 This lacks the concrete reason for sending the URL
melandory 2014/12/04 10:33:46 IMHO, "password detection" doesn't sound user-frie
+ </message>
<message name="IDS_MANAGE_PASSWORDS_CONFIRM_GENERATED_TEXT" desc="A message that the browser shows after saving a password it has autogenerated for the user. This message appears in a bubble and contains a link to all the user's saved autogenerated passwords. The link text is a separate string in the translation console and appears here as placeholder text.">
You can access it and all your <ph name="SAVED_PASSWORDS_LINK">$1<ex>Google saved passwords</ex></ph> from any browser.
</message>

Powered by Google App Engine
This is Rietveld 408576698