Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Unified Diff: components/password_manager/core/common/password_manager_ui.h

Issue 765073004: Adding skeleton code for showing Bubble, asking user to submit URL when Password Manager fails (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase on master Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/common/password_manager_ui.h
diff --git a/components/password_manager/core/common/password_manager_ui.h b/components/password_manager/core/common/password_manager_ui.h
index b7adbb4a5c7f52d8a4076609a7d3c0da774732d0..bbde56bc98cabf3fc611df291c22ad76a8351721 100644
--- a/components/password_manager/core/common/password_manager_ui.h
+++ b/components/password_manager/core/common/password_manager_ui.h
@@ -42,6 +42,16 @@ enum State {
// Credentials are pending, but we don't need to pop up a bubble.
CREDENTIAL_REQUEST_STATE,
+
+ // Password manager failed to detect the form, so bubble should be pop upped.
+ ASK_USER_REPORT_URL_STATE,
+
+ // Password manager failed to detect the form, bubble should outlive next
+ // navigation.
+ ASK_USER_REPORT_URL_BUBBLE_SHOWN_BEFORE_TRANSITION_STATE,
+
+ // "Allow to collect URL?" bubble is showing.
+ ASK_USER_REPORT_URL_BUBBLE_SHOWN_STATE,
};
// The position of a password item in a list of credentials.
@@ -63,6 +73,8 @@ bool IsCredentialsState(State state);
// interaction.
bool IsAutomaticDisplayState(State state);
+bool IsAskSubmitURLState(State state);
+
// Returns the state that the bubble should be in after the automatic display
// occurs.
State GetEndStateForAutomaticState(State state);

Powered by Google App Engine
This is Rietveld 408576698