components/password_manager/core/browser/password_manager_metrics_util.h - Issue 765073004: Adding skeleton code for showing Bubble, asking user to submit URL when Password Manager fails

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager_metrics_util.h

Issue 765073004: Adding skeleton code for showing Bubble, asking user to submit URL when Password Manager fails (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase on master Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/password_manager_client.cc ('k') | components/password_manager/core/common/password_manager_ui.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_manager_metrics_util.h

diff --git a/components/password_manager/core/browser/password_manager_metrics_util.h b/components/password_manager/core/browser/password_manager_metrics_util.h

index f9360079e1f5a65db4b23e8e268d599503fd6042..7eefde2229abbd5de93b04fb021c8a1263b5d2ba 100644

--- a/components/password_manager/core/browser/password_manager_metrics_util.h

+++ b/components/password_manager/core/browser/password_manager_metrics_util.h

@@ -46,6 +46,8 @@ enum UIDismissalReason {

CLICKED_UNBLACKLIST,

CLICKED_OK,

CLICKED_CREDENTIAL,

+ CLICKED_COLLECT_URL,

+ CLICKED_DO_NOT_COLLECT_URL,

NUM_UI_RESPONSES,

// If we add the omnibox icon _without_ intending to display the bubble,