Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client.cc

Issue 765073004: Adding skeleton code for showing Bubble, asking user to submit URL when Password Manager fails (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase on master Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/chrome_password_manager_client.cc
diff --git a/chrome/browser/password_manager/chrome_password_manager_client.cc b/chrome/browser/password_manager/chrome_password_manager_client.cc
index 0ad9df43ffb94fe6c980db669d15e1f2aa783695..874f5c59f4a2f54690d3b194f3da2ca4e520088a 100644
--- a/chrome/browser/password_manager/chrome_password_manager_client.cc
+++ b/chrome/browser/password_manager/chrome_password_manager_client.cc
@@ -131,9 +131,10 @@ bool ChromePasswordManagerClient::IsPasswordManagerEnabledForCurrentPage()
return entry->GetURL().host() != chrome::kChromeUIChromeSigninHost;
}
-bool ChromePasswordManagerClient::ShouldAskUserToSubmitURL() {
- return password_manager::urls_collection_experiment::ShouldShowBubble(
- GetPrefs());
+bool ChromePasswordManagerClient::ShouldAskUserToSubmitURL(const GURL& url) {
+ return url.is_valid() && !url.is_empty() && url.has_host() &&
+ password_manager::urls_collection_experiment::ShouldShowBubble(
+ GetPrefs());
}
bool ChromePasswordManagerClient::ShouldFilterAutofillResult(
@@ -167,9 +168,10 @@ bool ChromePasswordManagerClient::IsSyncAccountCredential(
}
void ChromePasswordManagerClient::AskUserAndMaybeReportURL(
- const std::string& url) const {
- // TODO(melandory) Show bubble which asks user if he wants to report the URL
- // and report URL if needed.
+ const GURL& url) const {
+ ManagePasswordsUIController* manage_passwords_ui_controller =
+ ManagePasswordsUIController::FromWebContents(web_contents());
+ manage_passwords_ui_controller->OnAskToReportURL(url);
}
void ChromePasswordManagerClient::AutofillResultsComputed() {

Powered by Google App Engine
This is Rietveld 408576698