chrome/browser/password_manager/chrome_password_manager_client_unittest.cc - Issue 765073004: Adding skeleton code for showing Bubble, asking user to submit URL when Password Manager fails

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client_unittest.cc

Issue 765073004: Adding skeleton code for showing Bubble, asking user to submit URL when Password Manager fails (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase on master Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/chrome_password_manager_client.cc ('k') | chrome/browser/ui/passwords/manage_passwords_bubble_model.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/chrome_password_manager_client_unittest.cc

diff --git a/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc b/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc

index fb35ebb2b5c7aab85ab9f0004f38beec859ceaa7..3690362846b3a9bb5c478abad02eb30f55d8380d 100644

--- a/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc

+++ b/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc

@@ -228,7 +228,12 @@ TEST_F(ChromePasswordManagerClientTest,

ChromePasswordManagerClient* client = GetClient();

// TODO(melandory) Since "Ask user to submit URL" functionality is currently

// in development, so the user should not be asked to submit a URL.

- EXPECT_FALSE(client->ShouldAskUserToSubmitURL());

+ EXPECT_FALSE(client->ShouldAskUserToSubmitURL(GURL("https://hostname.com/")));

+TEST_F(ChromePasswordManagerClientTest, ShouldAskUserToSubmitURLEmptyURL) {

+ ChromePasswordManagerClient* client = GetClient();

+ EXPECT_FALSE(client->ShouldAskUserToSubmitURL(GURL::EmptyGURL()));

}

TEST_F(ChromePasswordManagerClientTest, ShouldFilterAutofillResult_Reauth) {