Adding skeleton code for showing Bubble, asking user to submit URL when Password Manager fails

components/password_manager/core/common/password_manager_ui.h

Index: components/password_manager/core/common/password_manager_ui.h
diff --git a/components/password_manager/core/common/password_manager_ui.h b/components/password_manager/core/common/password_manager_ui.h
index b7adbb4a5c7f52d8a4076609a7d3c0da774732d0..416c1eef46d6ada773c38dcac336fc4899de40e6 100644
--- a/components/password_manager/core/common/password_manager_ui.h
+++ b/components/password_manager/core/common/password_manager_ui.h
@@ -42,6 +42,16 @@ enum State {
 
   // Credentials are pending, but we don't need to pop up a bubble.
   CREDENTIAL_REQUEST_STATE,
+
+  // Password manager failed to detect the form, so bubble should be pop upped.
+  ASK_USER_REPORT_URL_BEFORE_LOAD_STATE,

[vabr (Chromium), 2014/12/05 13:43:22]

My suggestion might be a silly one, but I suggest rotating the state names
forward by one step. As they are now, the names do not seem to me to match the
meanings. My suggestion would be:

ASK_USER_REPORT_URL_AND_PENDING_BUBBLE_STATE -- the very first state. The bubble
is not shown yet, but should be (hence "pending bubble").

ASK_USER_REPORT_URL_BEFORE_LOAD_STATE -- the state when the bubble has already
been displayed, but the page navigation ("load") did not occur yet.

ASK_USER_REPORT_URL_AFTER_LOAD_STATE -- the state after the navigation ("load"),
when the bubble is either still displayed, or can be displayed by the user
clicking on the key icon.

[vabr (Chromium), 2014/12/05 13:53:42]

ASK_USER_REPORT_URL_STATE

+
+  // Password manager failed to detect the form, bubble should outlive next
+  // navigation.
+  ASK_USER_REPORT_URL_AFTER_LOAD_STATE,

[vabr (Chromium), 2014/12/05 13:53:42]

ASK_USER_REPORT_URL_BUBBLE_SHOWN_BEFORE_TRANSITION_STATE

+
+  // "Allow to collect URL?" bubble is showing.
+  ASK_USER_TO_REPORT_URL_AND_PENDING_BUBBLE_STATE,

[vabr (Chromium), 2014/12/05 13:53:42]

ASK_USER_REPORT_URL_BUBBLE_SHOWN_STATE

 };
 
 // The position of a password item in a list of credentials.
@@ -63,6 +73,8 @@ bool IsCredentialsState(State state);
 // interaction.
 bool IsAutomaticDisplayState(State state);
 
+bool IsAskSubmitURLState(State state);
+
 // Returns the state that the bubble should be in after the automatic display
 // occurs.
 State GetEndStateForAutomaticState(State state);