Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Unified Diff: components/password_manager/core/common/password_manager_ui.cc

Issue 765073004: Adding skeleton code for showing Bubble, asking user to submit URL when Password Manager fails (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/common/password_manager_ui.cc
diff --git a/components/password_manager/core/common/password_manager_ui.cc b/components/password_manager/core/common/password_manager_ui.cc
index c8c2da77552ca3b98c34dd4c70e4b46345c21263..c7ea13578f131b371dfe9ce3d94fc52776326d65 100644
--- a/components/password_manager/core/common/password_manager_ui.cc
+++ b/components/password_manager/core/common/password_manager_ui.cc
@@ -14,6 +14,12 @@ bool IsPendingState(State state) {
state == PENDING_PASSWORD_STATE;
}
+bool IsAskSubmitURLState(State state) {
+ return state == ASK_USER_REPORT_URL_BEFORE_LOAD_STATE ||
+ state == ASK_USER_REPORT_URL_AFTER_LOAD_STATE ||
+ state == ASK_USER_TO_REPORT_URL_AND_PENDING_BUBBLE_STATE;
+}
+
bool IsCredentialsState(State state) {
return (state == CREDENTIAL_REQUEST_STATE ||
state == CREDENTIAL_REQUEST_AND_BUBBLE_STATE);
@@ -21,6 +27,7 @@ bool IsCredentialsState(State state) {
bool IsAutomaticDisplayState(State state) {
return state == PENDING_PASSWORD_AND_BUBBLE_STATE ||
+ state == ASK_USER_REPORT_URL_BEFORE_LOAD_STATE ||
state == CONFIRMATION_STATE ||
state == CREDENTIAL_REQUEST_AND_BUBBLE_STATE;
}
@@ -34,6 +41,8 @@ State GetEndStateForAutomaticState(State state) {
return MANAGE_STATE;
case CREDENTIAL_REQUEST_AND_BUBBLE_STATE:
return CREDENTIAL_REQUEST_STATE;
+ case ASK_USER_REPORT_URL_BEFORE_LOAD_STATE:
+ return ASK_USER_REPORT_URL_AFTER_LOAD_STATE;
default:
NOTREACHED();
return INACTIVE_STATE;

Powered by Google App Engine
This is Rietveld 408576698