components/password_manager/core/browser/password_manager_client.cc - Issue 765073004: Adding skeleton code for showing Bubble, asking user to submit URL when Password Manager fails

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager_client.cc

Issue 765073004: Adding skeleton code for showing Bubble, asking user to submit URL when Password Manager fails (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc ('K') | « components/password_manager/core/browser/password_manager_client.h ('k') | components/password_manager/core/browser/password_manager_metrics_util.h » ('j') | components/password_manager/core/common/password_manager_ui.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_manager_client.cc

diff --git a/components/password_manager/core/browser/password_manager_client.cc b/components/password_manager/core/browser/password_manager_client.cc

index c914e4e7117456491ffcffb8b80658f88030a422..f3b539ce070caad01f2c33542a3aaea75ea2d357 100644

--- a/components/password_manager/core/browser/password_manager_client.cc

+++ b/components/password_manager/core/browser/password_manager_client.cc

@@ -20,8 +20,7 @@ PasswordManagerClient::GetProbabilityForExperiment(

return 0;

}

-void PasswordManagerClient::AskUserAndMaybeReportURL(

- const std::string& url) const {

+void PasswordManagerClient::AskUserAndMaybeReportURL(const GURL& url) const {

}

bool PasswordManagerClient::IsPasswordSyncEnabled(CustomPassphraseState state) {

@@ -40,7 +39,7 @@ bool PasswordManagerClient::IsLoggingActive() const {

return false;

}

-bool PasswordManagerClient::ShouldAskUserToSubmitURL() {

+bool PasswordManagerClient::ShouldAskUserToSubmitURL(const GURL& url) {

return false;

}