Adding skeleton code for showing Bubble, asking user to submit URL when Password Manager fails

components/password_manager/core/common/password_manager_ui.h

Index: components/password_manager/core/common/password_manager_ui.h
diff --git a/components/password_manager/core/common/password_manager_ui.h b/components/password_manager/core/common/password_manager_ui.h
index b7adbb4a5c7f52d8a4076609a7d3c0da774732d0..e4cf24455551a9d95dbee75407d296f91ea67554 100644
--- a/components/password_manager/core/common/password_manager_ui.h
+++ b/components/password_manager/core/common/password_manager_ui.h
@@ -42,6 +42,18 @@ enum State {
 
   // Credentials are pending, but we don't need to pop up a bubble.
   CREDENTIAL_REQUEST_STATE,
+
+  // Password manager failed to detect the form, but we don't need to pop up a

[vabr (Chromium), 2014/12/04 13:25:33]

I'm rather confused about the names and meanings of the three new states. I'll
come over to you and ask.

[melandory, 2014/12/05 12:56:53]

Done.

+  // bubble.
+  ASK_USER_TO_REPORT_URL_STATE,

[vabr (Chromium), 2014/12/04 13:25:33]

I find confusing that this is about asking the user, but at the same time we
don't need to pop up a bubble. It looks like a relic from the previous naming
scheme.

Is it at all possible to display this bubble manually, by clicking on the key
icon?

If yes, then we should just rename this and change the code comment on lines
46-47 to something explaining that this is the state just before the bubble is
opened automatically for the sake of asking the user about reporting the URL.

If not, then we should simply merge this state with the next one.

[melandory, 2014/12/05 12:56:52]

Done.

+
+  // Password manager failed to detect the form, bubble should pop up on next
+  // navigation.
+  ASK_USER_TO_REPORT_URL_AFTER_NEXT_LOAD_STATE,

[vabr (Chromium), 2014/12/04 13:25:33]

Neither this state, nor the one above seems to be mentioned in any of the tests.
Could we increase the coverage?

[melandory, 2014/12/05 12:56:53]

Done.

+
+  // Now we need to ask users if thew want to report the URL by showing

[vabr (Chromium), 2014/12/04 13:25:33]

typo: thew -> they

[melandory, 2014/12/05 12:56:53]

Done.

+  // "Allow to submit URL?" bubble.
+  ASK_USER_TO_REPORT_URL_AND_BUBBLE_STATE,
 };
 
 // The position of a password item in a list of credentials.
@@ -63,6 +75,8 @@ bool IsCredentialsState(State state);
 // interaction.
 bool IsAutomaticDisplayState(State state);
 
+bool IsAskSubmitURLState(State state);
+
 // Returns the state that the bubble should be in after the automatic display
 // occurs.
 State GetEndStateForAutomaticState(State state);