chrome/browser/ui/browser_command_controller.cc - Issue 765043002: Bookmark pop-up doesn't open if Ctrl+D is set as keyboard shortcut for added extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_command_controller.cc

Issue 765043002: Bookmark pop-up doesn't open if Ctrl+D is set as keyboard shortcut for added extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing nit. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/browser_command_controller.cc

diff --git a/chrome/browser/ui/browser_command_controller.cc b/chrome/browser/ui/browser_command_controller.cc

index a49e3386fa0915310cbdbf5ad3068628a596755e..6b8cb1143226d334a1ec0e5a4f5a9e6b2a03481a 100644

--- a/chrome/browser/ui/browser_command_controller.cc

+++ b/chrome/browser/ui/browser_command_controller.cc

@@ -528,7 +528,7 @@ void BrowserCommandController::ExecuteCommandWithDisposition(

SavePage(browser_);

break;

case IDC_BOOKMARK_PAGE:

- BookmarkCurrentPage(browser_);

+ BookmarkCurrentPageAllowingExtensionOverrides(browser_);

break;

case IDC_BOOKMARK_ALL_TABS:

BookmarkAllTabs(browser_);

« no previous file with comments | « chrome/browser/browser_commands_unittest.cc ('k') | chrome/browser/ui/browser_commands.h » ('j') | no next file with comments »