Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Side by Side Diff: chrome/browser/ui/browser_command_controller.cc

Issue 765043002: Bookmark pop-up doesn't open if Ctrl+D is set as keyboard shortcut for added extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing nit. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/browser_commands_unittest.cc ('k') | chrome/browser/ui/browser_commands.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/browser_command_controller.h" 5 #include "chrome/browser/ui/browser_command_controller.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/prefs/pref_service.h" 8 #include "base/prefs/pref_service.h"
9 #include "chrome/app/chrome_command_ids.h" 9 #include "chrome/app/chrome_command_ids.h"
10 #include "chrome/browser/browser_process.h" 10 #include "chrome/browser/browser_process.h"
(...skipping 510 matching lines...) Expand 10 before | Expand all | Expand 10 after
521 #endif 521 #endif
522 case IDC_EXIT: 522 case IDC_EXIT:
523 Exit(); 523 Exit();
524 break; 524 break;
525 525
526 // Page-related commands 526 // Page-related commands
527 case IDC_SAVE_PAGE: 527 case IDC_SAVE_PAGE:
528 SavePage(browser_); 528 SavePage(browser_);
529 break; 529 break;
530 case IDC_BOOKMARK_PAGE: 530 case IDC_BOOKMARK_PAGE:
531 BookmarkCurrentPage(browser_); 531 BookmarkCurrentPageAllowingExtensionOverrides(browser_);
532 break; 532 break;
533 case IDC_BOOKMARK_ALL_TABS: 533 case IDC_BOOKMARK_ALL_TABS:
534 BookmarkAllTabs(browser_); 534 BookmarkAllTabs(browser_);
535 break; 535 break;
536 case IDC_VIEW_SOURCE: 536 case IDC_VIEW_SOURCE:
537 ViewSelectedSource(browser_); 537 ViewSelectedSource(browser_);
538 break; 538 break;
539 case IDC_EMAIL_PAGE_LOCATION: 539 case IDC_EMAIL_PAGE_LOCATION:
540 EmailPageLocation(browser_); 540 EmailPageLocation(browser_);
541 break; 541 break;
(...skipping 800 matching lines...) Expand 10 before | Expand all | Expand 10 after
1342 1342
1343 BrowserWindow* BrowserCommandController::window() { 1343 BrowserWindow* BrowserCommandController::window() {
1344 return browser_->window(); 1344 return browser_->window();
1345 } 1345 }
1346 1346
1347 Profile* BrowserCommandController::profile() { 1347 Profile* BrowserCommandController::profile() {
1348 return browser_->profile(); 1348 return browser_->profile();
1349 } 1349 }
1350 1350
1351 } // namespace chrome 1351 } // namespace chrome
OLDNEW
« no previous file with comments | « chrome/browser/browser_commands_unittest.cc ('k') | chrome/browser/ui/browser_commands.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698