chrome/browser/ui/browser_commands.h - Issue 765043002: Bookmark pop-up doesn't open if Ctrl+D is set as keyboard shortcut for added extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_commands.h

Issue 765043002: Bookmark pop-up doesn't open if Ctrl+D is set as keyboard shortcut for added extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/browser_command_controller.cc ('k') | chrome/browser/ui/browser_commands.cc » ('j') | chrome/browser/ui/views/location_bar/star_view.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/browser_commands.h

diff --git a/chrome/browser/ui/browser_commands.h b/chrome/browser/ui/browser_commands.h

index b677e7d54608e43bfe3200a2ccd459548e80644f..d6df19d1316845c79f3e7b5c1bf693d5beb31e38 100644

--- a/chrome/browser/ui/browser_commands.h

+++ b/chrome/browser/ui/browser_commands.h

@@ -94,7 +94,8 @@ content::WebContents* DuplicateTabAt(Browser* browser, int index);

bool CanDuplicateTabAt(Browser* browser, int index);

void ConvertPopupToTabbedBrowser(Browser* browser);

void Exit();

-void BookmarkCurrentPage(Browser* browser);

+void BookmarkCurrentPageIgnoringExtensionOverrides(Browser* browser);

+void BookmarkCurrentPageAllowingExtensionOverrides(Browser* browser);

bool CanBookmarkCurrentPage(const Browser* browser);

void BookmarkAllTabs(Browser* browser);

bool CanBookmarkAllTabs(const Browser* browser);