chrome/browser/browser_commands_unittest.cc - Issue 765043002: Bookmark pop-up doesn't open if Ctrl+D is set as keyboard shortcut for added extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browser_commands_unittest.cc

Issue 765043002: Bookmark pop-up doesn't open if Ctrl+D is set as keyboard shortcut for added extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/browser_commands_unittest.cc

diff --git a/chrome/browser/browser_commands_unittest.cc b/chrome/browser/browser_commands_unittest.cc

index eb110ad154e836c1e6e9ba403a229d436272b339..b92d1733adff3053e57eaa32722ede5e401aaab3 100644

--- a/chrome/browser/browser_commands_unittest.cc

+++ b/chrome/browser/browser_commands_unittest.cc

@@ -149,7 +149,7 @@ TEST_F(BrowserCommandsTest, BookmarkCurrentPage) {

browser()->OpenURL(OpenURLParams(

url1, Referrer(), CURRENT_TAB, ui::PAGE_TRANSITION_TYPED, false));

- chrome::BookmarkCurrentPage(browser());

+ chrome::BookmarkCurrentPageAllowingExtensionOverrides(browser());

// It should now be bookmarked in the bookmark model.

EXPECT_EQ(profile(), browser()->profile());

« no previous file with comments | « no previous file | chrome/browser/ui/browser_command_controller.cc » ('j') | chrome/browser/ui/views/location_bar/star_view.h » ('J')