Bookmark pop-up doesn't open if Ctrl+D is set as keyboard shortcut for added extensions.

chrome/browser/ui/views/location_bar/bubble_icon_view.cc

Index: chrome/browser/ui/views/location_bar/bubble_icon_view.cc
diff --git a/chrome/browser/ui/views/location_bar/bubble_icon_view.cc b/chrome/browser/ui/views/location_bar/bubble_icon_view.cc
index d74f32937b6aa3edd0a181bb149c653e97b45caf..01dcd52a53d6bea1c0bd785670e59732fd5b3dd8 100644
--- a/chrome/browser/ui/views/location_bar/bubble_icon_view.cc
+++ b/chrome/browser/ui/views/location_bar/bubble_icon_view.cc
@@ -49,8 +49,12 @@ void BubbleIconView::OnMouseReleased(const ui::MouseEvent& event) {
     return;
   }
 
-  if (event.IsOnlyLeftMouseButton() && HitTestPoint(event.location()))
+  if (event.IsOnlyLeftMouseButton() && HitTestPoint(event.location()) &&
+      command_updater_) {

[Finnur, 2014/12/03 10:49:17]

This cannot possibly be correct. A cursory glance at how BubbleIconView is used
in the code, shows that at least the ZoomView constructs it with a
command_updater that is a nullptr. So, line 53 looks like it breaks the ZoomView
(it won't execute the command anymore, as line 55 never gets called).

But this whole patch feels like a big ugly hack that can be handled in a
different way and more elegantly.

+    command_updater_->set_bookmark_icon_selected(true);
     ExecuteCommand(EXECUTE_SOURCE_MOUSE);
+    command_updater_->set_bookmark_icon_selected(false);
+  }
 }
 
 bool BubbleIconView::OnKeyPressed(const ui::KeyEvent& event) {