Bookmark pop-up doesn't open if Ctrl+D is set as keyboard shortcut for added extensions.

chrome/browser/ui/views/location_bar/bubble_icon_view.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/location_bar/bubble_icon_view.h"
 
 #include "chrome/browser/command_updater.h"
 #include "ui/accessibility/ax_view_state.h"
 #include "ui/events/event.h"
 
@@ skipping 31 matching lines @@
 
 void BubbleIconView::OnMouseReleased(const ui::MouseEvent& event) {
   // If this is the second click on this view then the bubble was showing on the
   // mouse pressed event and is hidden now. Prevent the bubble from reshowing by
   // doing nothing here.
   if (suppress_mouse_released_action_) {
     suppress_mouse_released_action_ = false;
     return;
   }
 
-  if (event.IsOnlyLeftMouseButton() && HitTestPoint(event.location()))
+  if (event.IsOnlyLeftMouseButton() && HitTestPoint(event.location()) &&
+      command_updater_) {

[Finnur, 2014/12/03 10:49:17]

This cannot possibly be correct. A cursory glance at how BubbleIconView is used
in the code, shows that at least the ZoomView constructs it with a
command_updater that is a nullptr. So, line 53 looks like it breaks the ZoomView
(it won't execute the command anymore, as line 55 never gets called).

But this whole patch feels like a big ugly hack that can be handled in a
different way and more elegantly.

+    command_updater_->set_bookmark_icon_selected(true);
     ExecuteCommand(EXECUTE_SOURCE_MOUSE);
+    command_updater_->set_bookmark_icon_selected(false);
+  }
 }
 
 bool BubbleIconView::OnKeyPressed(const ui::KeyEvent& event) {
   if (event.key_code() == ui::VKEY_SPACE ||
       event.key_code() == ui::VKEY_RETURN) {
     ExecuteCommand(EXECUTE_SOURCE_KEYBOARD);
     return true;
   }
   return false;
 }
 
 void BubbleIconView::OnGestureEvent(ui::GestureEvent* event) {
   if (event->type() == ui::ET_GESTURE_TAP) {
     ExecuteCommand(EXECUTE_SOURCE_GESTURE);
     event->SetHandled();
   }
 }
 
 void BubbleIconView::ExecuteCommand(ExecuteSource source) {
   OnExecuting(source);
   if (command_updater_)
     command_updater_->ExecuteCommand(command_id_);
 }