Issue 7650010: Avoid some crashes when running without snapshots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7650010: Avoid some crashes when running without snapshots. (Closed)

Created:
9 years, 4 months ago by Lasse Reichstein

Modified:
9 years, 4 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev, mnaganov (inactive)

Base URL:
https://v8.googlecode.com/svn/branches/experimental/gc

Visibility:
Public.

Description

Avoid some crashes when running without snapshots. Make many more tests succeede with snapshots off. Committed: http://code.google.com/p/v8/source/detail?r=8937

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review comments #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+165 lines, -82 lines)			Patch
M	src/debug.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/heap.h	View	1	4 chunks	+22 lines, -7 lines	0 comments	Download
M	src/heap.cc	View	1	8 chunks	+60 lines, -14 lines	0 comments	Download
M	src/liveedit.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/log.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/objects.h	View		1 chunk	+2 lines, -6 lines	0 comments	Download
M	src/profile-generator.h	View		3 chunks	+5 lines, -6 lines	0 comments	Download
M	src/profile-generator.cc	View		6 chunks	+41 lines, -21 lines	0 comments	Download
M	src/runtime.cc	View	1	12 chunks	+22 lines, -16 lines	0 comments	Download
M	src/spaces.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	test/cctest/test-api.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-debug.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-heap.cc	View		3 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

Replaces 7618041 which failed to upload completely.

9 years, 4 months ago (2011-08-15 13:07:36 UTC) #1

Vyacheslav Egorov (Chromium)

9 years, 4 months ago (2011-08-15 13:17:33 UTC) #2

LGTM

http://codereview.chromium.org/7650010/diff/1/src/runtime.cc
File src/runtime.cc (right):

http://codereview.chromium.org/7650010/diff/1/src/runtime.cc#newcode11734
src/runtime.cc:11734: // TODO(gc): Ensure that the heap is still iterable. Can
the allocation
We are not adding TODO(gc)

http://codereview.chromium.org/7650010/diff/1/src/runtime.cc#newcode11815
src/runtime.cc:11815: // TODO(gc): Prevent conservative scanning to ensure that
heap is iterable.
Ditto

Expand Messages | Collapse Messages