Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 7650: Move more platform-specific stuff from WebContents to the view.... (Closed)

Created:
12 years, 2 months ago by brettw
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Move more platform-specific stuff from WebContents to the view. I refactored the way title setting is done since there were two parts that duplicated the logic and did so slightly differently. I removed some old code in RendererGone whose premise is no longer valid and had the effect of creating a bug with no benefit. I moved the sad tab view from WebContents to the view. Amusingly, the view was the only one using this, but it would go poke inside of the WebContents to get it. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=3601

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -187 lines) Patch
M chrome/browser/render_view_host.cc View 4 chunks +25 lines, -8 lines 0 comments Download
M chrome/browser/render_view_host_delegate.h View 4 chunks +23 lines, -23 lines 0 comments Download
M chrome/browser/web_contents.h View 7 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/web_contents.cc View 1 2 10 chunks +48 lines, -93 lines 1 comment Download
M chrome/browser/web_contents_view.h View 4 chunks +16 lines, -22 lines 0 comments Download
M chrome/browser/web_contents_view_win.h View 4 chunks +14 lines, -5 lines 0 comments Download
M chrome/browser/web_contents_view_win.cc View 3 chunks +49 lines, -22 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
12 years, 2 months ago (2008-10-18 04:53:22 UTC) #1
Ben Goodger (Google)
12 years, 2 months ago (2008-10-18 05:08:13 UTC) #2
OK

http://codereview.chromium.org/7650/diff/17/212
File chrome/browser/web_contents.cc (right):

http://codereview.chromium.org/7650/diff/17/212#newcode1727
Line 1727: if (final_title != entry->title())
do you mean ==?

Powered by Google App Engine
This is Rietveld 408576698