Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Unified Diff: chrome/browser/render_view_host_delegate.h

Issue 7650: Move more platform-specific stuff from WebContents to the view.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 12 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/render_view_host_delegate.h
===================================================================
--- chrome/browser/render_view_host_delegate.h (revision 3558)
+++ chrome/browser/render_view_host_delegate.h (working copy)
@@ -76,6 +76,29 @@
// The widget is identified by the route_id passed to CreateNewWidget.
virtual void ShowCreatedWidget(int route_id,
const gfx::Rect& initial_pos) = 0;
+
+ // A context menu should be shown, to be built using the context information
+ // provided in the supplied params.
+ virtual void ShowContextMenu(
+ const ViewHostMsg_ContextMenu_Params& params) = 0;
+
+ // The user started dragging content of the specified type within the
+ // RenderView. Contextual information about the dragged content is supplied
+ // by WebDropData.
+ virtual void StartDragging(const WebDropData& drop_data) = 0;
+
+ // The page wants to update the mouse cursor during a drag & drop operation.
+ // |is_drop_target| is true if the mouse is over a valid drop target.
+ virtual void UpdateDragCursor(bool is_drop_target) = 0;
+
+ // Callback to inform the browser it should take back focus. If reverse is
+ // true, it means the focus was retrieved by doing a Shift-Tab.
+ virtual void TakeFocus(bool reverse) = 0;
+
+ // Callback to inform the browser that the renderer did not process the
+ // specified events. This gives an opportunity to the browser to process the
+ // event (used for keyboard shortcuts).
+ virtual void HandleKeyboardEvent(const WebKeyboardEvent& event) = 0;
};
class FindInPage {
@@ -208,20 +231,6 @@
bool errored,
const SkBitmap& image) { }
- // A context menu should be shown, to be built using the context information
- // provided in the supplied params.
- virtual void ShowContextMenu(const ViewHostMsg_ContextMenu_Params& params) {
- }
-
- // The user started dragging content of the specified type within the
- // RenderView. Contextual information about the dragged content is supplied
- // by WebDropData.
- virtual void StartDragging(const WebDropData& drop_data) { }
-
- // The page wants to update the mouse cursor during a drag & drop operation.
- // |is_drop_target| is true if the mouse is over a valid drop target.
- virtual void UpdateDragCursor(bool is_drop_target) { }
-
// The page wants to open a URL with the specified disposition.
virtual void RequestOpenURL(const GURL& url,
WindowOpenDisposition disposition) { }
@@ -274,10 +283,6 @@
// Password forms have been detected in the page.
virtual void PasswordFormsSeen(const std::vector<PasswordForm>& forms) { }
- // Callback to inform the browser it should take back focus. If reverse is
- // true, it means the focus was retrieved by doing a Shift-Tab.
- virtual void TakeFocus(bool reverse) { }
-
// Notification that the page has an OpenSearch description document.
virtual void PageHasOSDD(RenderViewHost* render_view_host,
int32 page_id, const GURL& doc_url,
@@ -299,11 +304,6 @@
NOTREACHED();
}
- // Callback to inform the browser that the renderer did not process the
- // specified events. This gives an opportunity to the browser to process the
- // event (used for keyboard shortcuts).
- virtual void HandleKeyboardEvent(const WebKeyboardEvent& event) { }
-
// |url| is assigned to a server that can provide alternate error pages. If
// unchanged, just use the error pages built into our webkit.
virtual GURL GetAlternateErrorPageURL() const {

Powered by Google App Engine
This is Rietveld 408576698