Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 764963002: Document.write should always be processed synchronously regardless of bg parser (Closed)

Created:
6 years ago by kouhei (in TOK)
Modified:
6 years ago
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Document.write should always be processed synchronously regardless of bg parser Before this CL, document.write() was not processed synchronously when there are pending ParsedChunks from BackgroundHTMLParser. HTMLParserScheduler historically used to control both BackgroundHTMLParser pumps and asynchronous main thread parsing. Now that main thread parsing is only used for synchronous parsing, there is no reason that main thread parsing path should query HTMLParserScheduler status. This CL modifies pumpTokenizerIfPossible(), which is a method used only in main thread parsing, to not wait for HTMLParserScheduler to schedule its pumping. This CL addresses flakinesses seen in inspector/sources/debugger tests from Blink Scheduler changes. TESTS=inspector/sources/debugger/ BUG=437176 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186159

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -9 lines) Patch
M Source/core/html/parser/HTMLDocumentParser.cpp View 2 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
kouhei (in TOK)
Would you take a look?
6 years ago (2014-11-28 01:53:04 UTC) #2
Yuta Kitamura
Based on the change description, this patch seems fine. LGTM
6 years ago (2014-11-28 08:00:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/764963002/1
6 years ago (2014-11-28 08:19:37 UTC) #5
commit-bot: I haz the power
6 years ago (2014-11-28 08:21:32 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186159

Powered by Google App Engine
This is Rietveld 408576698