Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 764803002: Set clang directory in gyp. (Closed)

Created:
6 years ago by Michael Achenbach
Modified:
6 years ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Set clang directory in gyp. BUG=

Patch Set 1 #

Total comments: 4

Patch Set 2 : clang_xcode variable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M build/standalone.gypi View 1 2 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Michael Achenbach
PTAL
6 years ago (2014-11-27 11:56:28 UTC) #2
Michael Achenbach
https://codereview.chromium.org/764803002/diff/1/build/standalone.gypi File build/standalone.gypi (right): https://codereview.chromium.org/764803002/diff/1/build/standalone.gypi#newcode36 build/standalone.gypi:36: 'make_clang_dir%': '../third_party/llvm-build/Release+Asserts', In common.gypi I saw the usages of ...
6 years ago (2014-11-27 11:58:02 UTC) #3
Jakob Kummerow
lgtm https://codereview.chromium.org/764803002/diff/1/build/standalone.gypi File build/standalone.gypi (right): https://codereview.chromium.org/764803002/diff/1/build/standalone.gypi#newcode36 build/standalone.gypi:36: 'make_clang_dir%': '../third_party/llvm-build/Release+Asserts', On 2014/11/27 11:58:02, Michael Achenbach wrote: ...
6 years ago (2014-11-27 12:44:14 UTC) #4
jochen (gone - plz use gerrit)
lgtm https://codereview.chromium.org/764803002/diff/1/build/standalone.gypi File build/standalone.gypi (right): https://codereview.chromium.org/764803002/diff/1/build/standalone.gypi#newcode36 build/standalone.gypi:36: 'make_clang_dir%': '../third_party/llvm-build/Release+Asserts', On 2014/11/27 at 12:44:14, Jakob wrote: ...
6 years ago (2014-11-27 15:07:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/764803002/1
6 years ago (2014-11-27 16:25:07 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/1594)
6 years ago (2014-11-27 16:26:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/764803002/20001
6 years ago (2014-11-27 16:50:06 UTC) #11
commit-bot: I haz the power
6 years ago (2014-11-27 17:18:10 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001)

Powered by Google App Engine
This is Rietveld 408576698