 Chromium Code Reviews
 Chromium Code Reviews Issue 764803002:
  Set clang directory in gyp.  (Closed) 
  Base URL: https://chromium.googlesource.com/v8/v8.git@master
    
  
    Issue 764803002:
  Set clang directory in gyp.  (Closed) 
  Base URL: https://chromium.googlesource.com/v8/v8.git@master| OLD | NEW | 
|---|---|
| 1 # Copyright 2012 the V8 project authors. All rights reserved. | 1 # Copyright 2012 the V8 project authors. All rights reserved. | 
| 2 # Redistribution and use in source and binary forms, with or without | 2 # Redistribution and use in source and binary forms, with or without | 
| 3 # modification, are permitted provided that the following conditions are | 3 # modification, are permitted provided that the following conditions are | 
| 4 # met: | 4 # met: | 
| 5 # | 5 # | 
| 6 # * Redistributions of source code must retain the above copyright | 6 # * Redistributions of source code must retain the above copyright | 
| 7 # notice, this list of conditions and the following disclaimer. | 7 # notice, this list of conditions and the following disclaimer. | 
| 8 # * Redistributions in binary form must reproduce the above | 8 # * Redistributions in binary form must reproduce the above | 
| 9 # copyright notice, this list of conditions and the following | 9 # copyright notice, this list of conditions and the following | 
| 10 # disclaimer in the documentation and/or other materials provided | 10 # disclaimer in the documentation and/or other materials provided | 
| (...skipping 15 matching lines...) Expand all Loading... | |
| 26 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | 26 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | 
| 27 | 27 | 
| 28 # Definitions to be used when building stand-alone V8 binaries. | 28 # Definitions to be used when building stand-alone V8 binaries. | 
| 29 | 29 | 
| 30 { | 30 { | 
| 31 # We need to include toolchain.gypi here for third-party sources that don't | 31 # We need to include toolchain.gypi here for third-party sources that don't | 
| 32 # directly include it themselves. | 32 # directly include it themselves. | 
| 33 'includes': ['toolchain.gypi'], | 33 'includes': ['toolchain.gypi'], | 
| 34 'variables': { | 34 'variables': { | 
| 35 'component%': 'static_library', | 35 'component%': 'static_library', | 
| 36 'make_clang_dir%': '../third_party/llvm-build/Release+Asserts', | |
| 
Michael Achenbach
2014/11/27 11:58:02
In common.gypi I saw the usages of <(DEPTH) but th
 
Jakob Kummerow
2014/11/27 12:44:14
Black magic. I would think that <(DEPTH) should wo
 
jochen (gone - plz use gerrit)
2014/11/27 15:07:57
we shouldn't use DEPTH here, it's only useful for
 | |
| 36 'asan%': 0, | 37 'asan%': 0, | 
| 37 'tsan%': 0, | 38 'tsan%': 0, | 
| 38 'visibility%': 'hidden', | 39 'visibility%': 'hidden', | 
| 39 'v8_enable_backtrace%': 0, | 40 'v8_enable_backtrace%': 0, | 
| 40 'v8_enable_i18n_support%': 1, | 41 'v8_enable_i18n_support%': 1, | 
| 41 'v8_deprecation_warnings': 1, | 42 'v8_deprecation_warnings': 1, | 
| 42 'msvs_multi_core_compile%': '1', | 43 'msvs_multi_core_compile%': '1', | 
| 43 'mac_deployment_target%': '10.5', | 44 'mac_deployment_target%': '10.5', | 
| 44 'variables': { | 45 'variables': { | 
| 45 'variables': { | 46 'variables': { | 
| (...skipping 379 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 425 }, | 426 }, | 
| 426 }], | 427 }], | 
| 427 ], | 428 ], | 
| 428 'target_conditions': [ | 429 'target_conditions': [ | 
| 429 ['_type!="static_library"', { | 430 ['_type!="static_library"', { | 
| 430 'xcode_settings': {'OTHER_LDFLAGS': ['-Wl,-search_paths_first']}, | 431 'xcode_settings': {'OTHER_LDFLAGS': ['-Wl,-search_paths_first']}, | 
| 431 }], | 432 }], | 
| 432 ], # target_conditions | 433 ], # target_conditions | 
| 433 }, # target_defaults | 434 }, # target_defaults | 
| 434 }], # OS=="mac" | 435 }], # OS=="mac" | 
| 436 ['clang==1 and ((OS!="mac" and OS!="ios") or clang_xcode==0) ' | |
| 
Michael Achenbach
2014/11/27 11:58:02
This is copied 1:1 from common.gypi
 | |
| 437 'and OS!="win"', { | |
| 438 'make_global_settings': [ | |
| 439 ['CC', '<(make_clang_dir)/bin/clang'], | |
| 440 ['CXX', '<(make_clang_dir)/bin/clang++'], | |
| 441 ['CC.host', '$(CC)'], | |
| 442 ['CXX.host', '$(CXX)'], | |
| 443 ], | |
| 444 }], | |
| 445 ['clang==1 and OS=="win"', { | |
| 446 'make_global_settings': [ | |
| 447 # On Windows, gyp's ninja generator only looks at CC. | |
| 448 ['CC', '<(make_clang_dir)/bin/clang-cl'], | |
| 449 ], | |
| 450 }], | |
| 435 ], | 451 ], | 
| 436 } | 452 } | 
| OLD | NEW |