Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1953)

Unified Diff: content/renderer/v8_value_converter.cc

Issue 7647026: base: Add three helper functions to Values API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix a typo Ceate -> Create Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_view.cc ('k') | content/renderer/v8_value_converter_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/v8_value_converter.cc
diff --git a/content/renderer/v8_value_converter.cc b/content/renderer/v8_value_converter.cc
index d2c21cd2cc10ae3fcab2d4365873a8f0f93ae73b..08cc961a3a0b4fefd6c7c7dacc574308bcc2cb2e 100644
--- a/content/renderer/v8_value_converter.cc
+++ b/content/renderer/v8_value_converter.cc
@@ -119,7 +119,7 @@ Value* V8ValueConverter::FromV8ValueImpl(v8::Handle<v8::Value> val) const {
CHECK(!val.IsEmpty());
if (val->IsNull())
- return Value::CreateNullValue();
+ return base::NullValue();
if (val->IsBoolean())
return Value::CreateBooleanValue(val->ToBoolean()->Value());
@@ -136,7 +136,7 @@ Value* V8ValueConverter::FromV8ValueImpl(v8::Handle<v8::Value> val) const {
}
if (allow_undefined_ && val->IsUndefined())
- return Value::CreateNullValue();
+ return base::NullValue();
if (allow_date_ && val->IsDate()) {
v8::Date* date = v8::Date::Cast(*val);
@@ -156,7 +156,7 @@ Value* V8ValueConverter::FromV8ValueImpl(v8::Handle<v8::Value> val) const {
return FromV8Object(val->ToObject());
LOG(ERROR) << "Unexpected v8 value type encountered.";
- return Value::CreateNullValue();
+ return base::NullValue();
}
ListValue* V8ValueConverter::FromV8Array(v8::Handle<v8::Array> val) const {
« no previous file with comments | « content/renderer/render_view.cc ('k') | content/renderer/v8_value_converter_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698