Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: chrome/common/common_param_traits_unittest.cc

Issue 7647026: base: Add three helper functions to Values API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix a typo Ceate -> Create Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/sync_internals_ui_unittest.cc ('k') | chrome/common/json_pref_store_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/common_param_traits_unittest.cc
diff --git a/chrome/common/common_param_traits_unittest.cc b/chrome/common/common_param_traits_unittest.cc
index bc4741873a54366eaf196fd54df7d1f1f20ce0b6..d95c2780812307a9329463f60cb687a1cefb8720 100644
--- a/chrome/common/common_param_traits_unittest.cc
+++ b/chrome/common/common_param_traits_unittest.cc
@@ -119,7 +119,7 @@ TEST(IPCMessageTest, ListValue) {
ListValue input;
input.Set(0, Value::CreateDoubleValue(42.42));
input.Set(1, Value::CreateStringValue("forty"));
- input.Set(2, Value::CreateNullValue());
+ input.Set(2, base::NullValue());
IPC::Message msg(1, 2, IPC::Message::PRIORITY_NORMAL);
IPC::WriteParam(&msg, input);
@@ -139,13 +139,13 @@ TEST(IPCMessageTest, ListValue) {
TEST(IPCMessageTest, DictionaryValue) {
DictionaryValue input;
- input.Set("null", Value::CreateNullValue());
- input.Set("bool", Value::CreateBooleanValue(true));
+ input.Set("null", base::NullValue());
+ input.Set("bool", base::TrueValue());
input.Set("int", Value::CreateIntegerValue(42));
scoped_ptr<DictionaryValue> subdict(new DictionaryValue());
subdict->Set("str", Value::CreateStringValue("forty two"));
- subdict->Set("bool", Value::CreateBooleanValue(false));
+ subdict->Set("bool", base::FalseValue());
scoped_ptr<ListValue> sublist(new ListValue());
sublist->Set(0, Value::CreateDoubleValue(42.42));
« no previous file with comments | « chrome/browser/ui/webui/sync_internals_ui_unittest.cc ('k') | chrome/common/json_pref_store_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698