Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3465)

Unified Diff: chrome/browser/prefs/pref_service.cc

Issue 7647026: base: Add three helper functions to Values API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix a typo Ceate -> Create Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prefs/pref_service.cc
diff --git a/chrome/browser/prefs/pref_service.cc b/chrome/browser/prefs/pref_service.cc
index 6cb98364ed38ee4d05345c2c50f46859adb20509..61eef35d4e6871fa724a4b043af151d321470dad 100644
--- a/chrome/browser/prefs/pref_service.cc
+++ b/chrome/browser/prefs/pref_service.cc
@@ -46,9 +46,9 @@ Value* CreateLocaleDefaultValue(base::Value::Type type, int message_id) {
switch (type) {
case Value::TYPE_BOOLEAN: {
if ("true" == resource_string)
- return Value::CreateBooleanValue(true);
+ return base::TrueValue();
if ("false" == resource_string)
- return Value::CreateBooleanValue(false);
+ return base::FalseValue();
break;
}
@@ -74,7 +74,7 @@ Value* CreateLocaleDefaultValue(base::Value::Type type, int message_id) {
}
}
NOTREACHED();
- return Value::CreateNullValue();
+ return base::NullValue();
}
// Forwards a notification after a PostMessage so that we can wait for the
« no previous file with comments | « chrome/browser/prefs/pref_model_associator_unittest.cc ('k') | chrome/browser/prefs/pref_set_observer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698