Invoking constructors in js cps

Invoking constructors in js cps

R=karlklose@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42014

[sigurdm, 2014-11-26 14:18:29]

sigurdm@google.com changed reviewers:
+ karlklose@google.com

[karlklose, 2014-11-26 14:27:29]

LGTM.

https://codereview.chromium.org/764593002/diff/1/pkg/compiler/lib/src/js_back...
File pkg/compiler/lib/src/js_backend/codegen/codegen.dart (right):

https://codereview.chromium.org/764593002/diff/1/pkg/compiler/lib/src/js_back...
pkg/compiler/lib/src/js_backend/codegen/codegen.dart:168: 
Remove line.

https://codereview.chromium.org/764593002/diff/1/pkg/compiler/lib/src/js_back...
pkg/compiler/lib/src/js_backend/codegen/codegen.dart:171: js.Expression
compileConstant(ParameterElement parameter) {
Make that a member? It is currently only used here, but looks like we'll need it
in other places soon.

https://codereview.chromium.org/764593002/diff/1/pkg/compiler/lib/src/js_back...
pkg/compiler/lib/src/js_backend/codegen/codegen.dart:177:
selector.makeArgumentsList(arguments, target.implementation,
I think this should also have four spaces indentation.

https://codereview.chromium.org/764593002/diff/1/pkg/compiler/lib/src/js_back...
pkg/compiler/lib/src/js_backend/codegen/codegen.dart:186: return
buildStaticInvoke(node.selector, node.target, node.arguments);
Is there a common superclass of InvokeConstructor and InvokeStatic? Maybe there
should.

[sigurdm, 2014-11-26 14:49:52]

https://codereview.chromium.org/764593002/diff/1/pkg/compiler/lib/src/js_back...
File pkg/compiler/lib/src/js_backend/codegen/codegen.dart (right):

https://codereview.chromium.org/764593002/diff/1/pkg/compiler/lib/src/js_back...
pkg/compiler/lib/src/js_backend/codegen/codegen.dart:168: 
On 2014/11/26 14:27:29, karlklose wrote:
> Remove line.

Done.

https://codereview.chromium.org/764593002/diff/1/pkg/compiler/lib/src/js_back...
pkg/compiler/lib/src/js_backend/codegen/codegen.dart:171: js.Expression
compileConstant(ParameterElement parameter) {
On 2014/11/26 14:27:29, karlklose wrote:
> Make that a member? It is currently only used here, but looks like we'll need
it
> in other places soon.

Done.

https://codereview.chromium.org/764593002/diff/1/pkg/compiler/lib/src/js_back...
pkg/compiler/lib/src/js_backend/codegen/codegen.dart:177:
selector.makeArgumentsList(arguments, target.implementation,
On 2014/11/26 14:27:29, karlklose wrote:
> I think this should also have four spaces indentation.

Done.

https://codereview.chromium.org/764593002/diff/1/pkg/compiler/lib/src/js_back...
pkg/compiler/lib/src/js_backend/codegen/codegen.dart:186: return
buildStaticInvoke(node.selector, node.target, node.arguments);
On 2014/11/26 14:27:29, karlklose wrote:
> Is there a common superclass of InvokeConstructor and InvokeStatic? Maybe
there
> should.

There is `Invoke` but it is also common with InvokeMethod and thus has no
`target` getter. I thought passing selector, target and arguments explicitly
make buildStaticInvoke more general, and can be used if we later need to
generate static invokes that are not explicit in the IR.

[sigurdm, 2014-11-27 07:58:10]

Committed patchset #2 (id:20001) manually as 42014 (presubmit successful).