Invoking constructors in js cps

pkg/compiler/lib/src/js_backend/codegen/codegen.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library code_generator;
 
 import 'glue.dart';
 
 import '../../tree_ir/tree_ir_nodes.dart' as tree_ir;
 import '../../js/js.dart' as js;
@@ skipping 144 matching lines @@
   js.Expression visitConstant(tree_ir.Constant node) {
     return buildConstant(node.expression.value);
   }
 
   @override
   js.Expression visitFunctionExpression(tree_ir.FunctionExpression node) {
     return giveup(node);
     // TODO: implement visitFunctionExpression
   }
 
+  js.Expression buildStaticInvoke(Selector selector,
+                                  Element target,
+                                  List<tree_ir.Expression> arguments) {
+

[karlklose, 2014/11/26 14:27:29]

Remove line.

[sigurdm, 2014/11/26 14:49:52]

Done.

+    registry.registerStaticInvocation(target.declaration);
+
+    js.Expression compileConstant(ParameterElement parameter) {

[karlklose, 2014/11/26 14:27:29]

Make that a member? It is currently only used here, but looks like we'll need it
in other places soon.

[sigurdm, 2014/11/26 14:49:52]

Done.

+      return buildConstant(glue.getConstantForVariable(parameter).value);
+    }
+
+    js.Expression elementAccess = glue.elementAccess(target);
+    List<js.Expression> compiledArguments =
+      selector.makeArgumentsList(arguments, target.implementation,

[karlklose, 2014/11/26 14:27:29]

I think this should also have four spaces indentation.

[sigurdm, 2014/11/26 14:49:52]

Done.

+          visitExpression,
+          compileConstant);
+    return new js.Call(elementAccess, compiledArguments);
+  }
+
   @override
   js.Expression visitInvokeConstructor(tree_ir.InvokeConstructor node) {
-    return giveup(node);
-    // TODO: implement visitInvokeConstructor
+    if (node.constant != null) return giveup(node);
+    return buildStaticInvoke(node.selector, node.target, node.arguments);

[karlklose, 2014/11/26 14:27:29]

Is there a common superclass of InvokeConstructor and InvokeStatic? Maybe there
should.

[sigurdm, 2014/11/26 14:49:52]

There is `Invoke` but it is also common with InvokeMethod and thus has no
`target` getter. I thought passing selector, target and arguments explicitly
make buildStaticInvoke more general, and can be used if we later need to
generate static invokes that are not explicit in the IR.

   }
 
   @override
   js.Expression visitInvokeMethod(tree_ir.InvokeMethod node) {
     return giveup(node);
     // TODO: implement visitInvokeMethod
   }
 
   @override
   js.Expression visitInvokeStatic(tree_ir.InvokeStatic node) {
-    Element element = node.target;
-
-    registry.registerStaticInvocation(element.declaration);
-
-    js.Expression compileConstant(ParameterElement parameter) {
-      return buildConstant(glue.getConstantForVariable(parameter).value);
-    }
-
-    js.Expression elementAccess = glue.elementAccess(node.target);
-    List<js.Expression> arguments =
-      node.selector.makeArgumentsList(node.arguments, element.implementation,
-          visitExpression,
-          compileConstant);
-    return new js.Call(elementAccess, arguments);
+    return buildStaticInvoke(node.selector, node.target, node.arguments);
   }
 
   @override
   js.Expression visitInvokeSuperMethod(tree_ir.InvokeSuperMethod node) {
     return giveup(node);
     // TODO: implement visitInvokeSuperMethod
   }
 
   @override
   js.Expression visitLiteralList(tree_ir.LiteralList node) {
@@ skipping 168 matching lines @@
     accumulator.add(
         buildWhile(new js.LiteralBool(true), node.body, node.label, node));
   }
 
   @override
   void visitReturn(tree_ir.Return node) {
     accumulator.add(new js.Return(visitExpression(node.value)));
   }
 
 }