Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 764503002: Make fast/multicol/break-properties independent of the size of <body>. (Closed)

Created:
6 years ago by andersr
Modified:
6 years ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Make fast/multicol/break-properties independent of the size of <body>. This test currently relies on our special behavior when <html> and <body> explicitly disagree on 'direction' or 'writing-mode'. I wish to change that behavior, so I removed that dependency here by checking which column the boxes are placed in rather than its exact position in two dimensions. To simplify calculations, the body margin is now equal to the column-gap. Also, since it has no effect on the test, the multicol container is now much smaller to avoid overflow in the vertical-lr/rl versions of the test. R=mstensho@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186112

Patch Set 1 #

Total comments: 8

Patch Set 2 : Count from zero, padding:8px, remove <body>. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -37 lines) Patch
M LayoutTests/fast/multicol/break-properties.html View 1 2 chunks +13 lines, -9 lines 0 comments Download
M LayoutTests/fast/multicol/break-properties-expected.txt View 1 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/multicol/vertical-lr/break-properties.html View 1 2 chunks +13 lines, -9 lines 0 comments Download
M LayoutTests/fast/multicol/vertical-lr/break-properties-expected.txt View 1 1 chunk +3 lines, -2 lines 0 comments Download
M LayoutTests/fast/multicol/vertical-rl/break-properties.html View 1 2 chunks +13 lines, -12 lines 0 comments Download
M LayoutTests/fast/multicol/vertical-rl/break-properties-expected.txt View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
andersr
Related: https://codereview.chromium.org/758073003/
6 years ago (2014-11-26 10:19:33 UTC) #1
mstensho (USE GERRIT)
lgtm https://codereview.chromium.org/764503002/diff/1/LayoutTests/fast/multicol/break-properties.html File LayoutTests/fast/multicol/break-properties.html (right): https://codereview.chromium.org/764503002/diff/1/LayoutTests/fast/multicol/break-properties.html#newcode3 LayoutTests/fast/multicol/break-properties.html:3: body { margin: 5px; } Being explicit about ...
6 years ago (2014-11-27 10:37:54 UTC) #2
andersr
https://codereview.chromium.org/764503002/diff/1/LayoutTests/fast/multicol/break-properties.html File LayoutTests/fast/multicol/break-properties.html (right): https://codereview.chromium.org/764503002/diff/1/LayoutTests/fast/multicol/break-properties.html#newcode3 LayoutTests/fast/multicol/break-properties.html:3: body { margin: 5px; } On 2014/11/27 10:37:53, mstensho ...
6 years ago (2014-11-27 11:03:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/764503002/20001
6 years ago (2014-11-27 11:04:31 UTC) #5
commit-bot: I haz the power
6 years ago (2014-11-27 12:13:44 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186112

Powered by Google App Engine
This is Rietveld 408576698