Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(913)

Issue 763903003: bookmarks: Only try to get favicon for URL nodes. (Closed)

Created:
6 years ago by tfarina
Modified:
6 years ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, noyau+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

bookmarks: Only try to get favicon for URL nodes. Rearrange the logic to simplify it. And do it in terms of node's type. Also, it seems better to only call BookmarkModel's GetFavicon function on BookmarkNode URLs as we don't set favicon for folders. BUG=None TEST=open chrome, bookmark some pages, create some folders, drag them in-and-out around, no regressions should be observed. R=sky@chromium.org Committed: https://crrev.com/c0baf0baa80a7881f82d89ad8f5b917ef49598ec Cr-Commit-Position: refs/heads/master@{#307276}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -13 lines) Patch
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M components/bookmarks/browser/bookmark_model.cc View 2 chunks +5 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tfarina
6 years ago (2014-12-08 01:11:33 UTC) #2
sky
LGTM
6 years ago (2014-12-08 15:56:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/763903003/20001
6 years ago (2014-12-08 17:15:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:20001)
6 years ago (2014-12-08 18:01:29 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-08 18:02:40 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c0baf0baa80a7881f82d89ad8f5b917ef49598ec
Cr-Commit-Position: refs/heads/master@{#307276}

Powered by Google App Engine
This is Rietveld 408576698