bookmarks: Only try to get favicon for URL nodes.

chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/bookmarks/bookmark_bar_view.h"
 
 #include <algorithm>
 #include <limits>
 #include <string>
 #include <vector>
@@ skipping 1242 matching lines @@
 }
 
 void BookmarkBarView::WriteDragDataForView(View* sender,
                                            const gfx::Point& press_pt,
                                            ui::OSExchangeData* data) {
   content::RecordAction(UserMetricsAction("BookmarkBar_DragButton"));
 
   for (int i = 0; i < GetBookmarkButtonCount(); ++i) {
     if (sender == GetBookmarkButton(i)) {
       const BookmarkNode* node = model_->bookmark_bar_node()->GetChild(i);
-      const gfx::Image& image_from_model = model_->GetFavicon(node);
       const gfx::ImageSkia* icon = nullptr;
-      if (image_from_model.IsEmpty()) {
-        icon = GetImageSkiaNamed(node->is_folder() ? IDR_BOOKMARK_BAR_FOLDER
-                                                   : IDR_DEFAULT_FAVICON);
+      if (node->is_url()) {
+        const gfx::Image& image = model_->GetFavicon(node);
+        icon = image.IsEmpty() ? GetImageSkiaNamed(IDR_DEFAULT_FAVICON)
+                               : image.ToImageSkia();
       } else {
-        icon = image_from_model.ToImageSkia();
+        icon = GetImageSkiaNamed(IDR_BOOKMARK_BAR_FOLDER);
       }
 
       button_drag_utils::SetDragImage(node->url(),
                                       node->GetTitle(),
                                       *icon,
                                       &press_pt,
                                       data,
                                       GetBookmarkButton(i)->GetWidget());
       WriteBookmarkDragData(node, data);
       return;
@@ skipping 674 matching lines @@
     return;
   apps_page_shortcut_->SetVisible(visible);
   UpdateBookmarksSeparatorVisibility();
   LayoutAndPaint();
 }
 
 void BookmarkBarView::OnShowManagedBookmarksPrefChanged() {
   if (UpdateOtherAndManagedButtonsVisibility())
     LayoutAndPaint();
 }