Context menu in popup window is missing "Open link in new tab" and other items when right click on …

Context menu in popup window is missing "Open link in new tab" and other items when right click on link in extensions.

Link case was not handled for extensionsPopup.
Case added for handling link in Extension popup.

BUG=372255
Committed: https://crrev.com/e4c748eed0f0d9114ae4f0796f742ccf88c8d59d
Cr-Commit-Position: refs/heads/master@{#306340}

[Deepak, 2014-11-27 12:48:22]

deepak.m1@samsung.com changed reviewers:
+ lazyboy@chromium.org

[Deepak, 2014-11-27 12:48:22]

PTAL at my changes.
Thanks

[lazyboy, 2014-11-27 18:44:07]

lazyboy@chromium.org changed reviewers:
+ yoz@chromium.org

[lazyboy, 2014-11-27 18:44:08]

+Yoyo for one question.

https://codereview.chromium.org/763093002/diff/1/chrome/browser/renderer_cont...
File
chrome/browser/renderer_context_menu/context_menu_content_type_extension_popup.cc
(right):

https://codereview.chromium.org/763093002/diff/1/chrome/browser/renderer_cont...
chrome/browser/renderer_context_menu/context_menu_content_type_extension_popup.cc:18:
case ITEM_GROUP_LINK:
I don't see any issue with this, although this was always like this.

yoz@, do you know why we always disabled link menu items inside extension popup?

[Deepak, 2014-11-28 03:52:23]

On 2014/11/27 18:44:08, lazyboy wrote:
> +Yoyo for one question.
> 
>
https://codereview.chromium.org/763093002/diff/1/chrome/browser/renderer_cont...
> File
>
chrome/browser/renderer_context_menu/context_menu_content_type_extension_popup.cc
> (right):
> 
>
https://codereview.chromium.org/763093002/diff/1/chrome/browser/renderer_cont...
>
chrome/browser/renderer_context_menu/context_menu_content_type_extension_popup.cc:18:
> case ITEM_GROUP_LINK:
> I don't see any issue with this, although this was always like this.
> 
> yoz@, do you know why we always disabled link menu items inside extension
popup?

Similarly 
ITEM_GROUP_MEDIA_IMAGE also not present, due to this right click on image 
does not show proper context menu, only 'Inspect Element' context menu item
comes.

Is this behavior also intended for chrome extensions.

[Yoyo Zhou, 2014-12-01 17:47:42]

LGTM

https://codereview.chromium.org/763093002/diff/1/chrome/browser/renderer_cont...
File
chrome/browser/renderer_context_menu/context_menu_content_type_extension_popup.cc
(right):

https://codereview.chromium.org/763093002/diff/1/chrome/browser/renderer_cont...
chrome/browser/renderer_context_menu/context_menu_content_type_extension_popup.cc:18:
case ITEM_GROUP_LINK:
On 2014/11/27 18:44:07, lazyboy wrote:
> I don't see any issue with this, although this was always like this.
> 
> yoz@, do you know why we always disabled link menu items inside extension
popup?

I don't know why. It seems like an oversight.

[lazyboy, 2014-12-01 17:49:19]

OK, thanks for confirming.

LGTM

[Deepak, 2014-12-02 02:58:03]

The CQ bit was checked by deepak.m1@samsung.com

[commit-bot: I haz the power, 2014-12-02 02:58:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/763093002/1

[commit-bot: I haz the power, 2014-12-02 04:13:11]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-12-02 04:13:56]

Patchset 1 (id:??) landed as
https://crrev.com/e4c748eed0f0d9114ae4f0796f742ccf88c8d59d
Cr-Commit-Position: refs/heads/master@{#306340}