Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 763093002: Context menu in popup window is missing "Open link in new tab" and other items when right click on … (Closed)

Created:
6 years ago by Deepak
Modified:
6 years ago
Reviewers:
Yoyo Zhou, lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Context menu in popup window is missing "Open link in new tab" and other items when right click on link in extensions. Link case was not handled for extensionsPopup. Case added for handling link in Extension popup. BUG=372255 Committed: https://crrev.com/e4c748eed0f0d9114ae4f0796f742ccf88c8d59d Cr-Commit-Position: refs/heads/master@{#306340}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/renderer_context_menu/context_menu_content_type_extension_popup.cc View 1 chunk +1 line, -0 lines 2 comments Download

Messages

Total messages: 11 (3 generated)
Deepak
PTAL at my changes. Thanks
6 years ago (2014-11-27 12:48:22 UTC) #2
lazyboy
+Yoyo for one question. https://codereview.chromium.org/763093002/diff/1/chrome/browser/renderer_context_menu/context_menu_content_type_extension_popup.cc File chrome/browser/renderer_context_menu/context_menu_content_type_extension_popup.cc (right): https://codereview.chromium.org/763093002/diff/1/chrome/browser/renderer_context_menu/context_menu_content_type_extension_popup.cc#newcode18 chrome/browser/renderer_context_menu/context_menu_content_type_extension_popup.cc:18: case ITEM_GROUP_LINK: I don't see ...
6 years ago (2014-11-27 18:44:08 UTC) #4
Deepak
On 2014/11/27 18:44:08, lazyboy wrote: > +Yoyo for one question. > > https://codereview.chromium.org/763093002/diff/1/chrome/browser/renderer_context_menu/context_menu_content_type_extension_popup.cc > File ...
6 years ago (2014-11-28 03:52:23 UTC) #5
Yoyo Zhou
LGTM https://codereview.chromium.org/763093002/diff/1/chrome/browser/renderer_context_menu/context_menu_content_type_extension_popup.cc File chrome/browser/renderer_context_menu/context_menu_content_type_extension_popup.cc (right): https://codereview.chromium.org/763093002/diff/1/chrome/browser/renderer_context_menu/context_menu_content_type_extension_popup.cc#newcode18 chrome/browser/renderer_context_menu/context_menu_content_type_extension_popup.cc:18: case ITEM_GROUP_LINK: On 2014/11/27 18:44:07, lazyboy wrote: > ...
6 years ago (2014-12-01 17:47:42 UTC) #6
lazyboy
OK, thanks for confirming. LGTM
6 years ago (2014-12-01 17:49:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/763093002/1
6 years ago (2014-12-02 02:58:28 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-02 04:13:11 UTC) #10
commit-bot: I haz the power
6 years ago (2014-12-02 04:13:56 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e4c748eed0f0d9114ae4f0796f742ccf88c8d59d
Cr-Commit-Position: refs/heads/master@{#306340}

Powered by Google App Engine
This is Rietveld 408576698