chrome/browser/renderer_context_menu/context_menu_content_type_extension_popup.cc - Issue 763093002: Context menu in popup window is missing "Open link in new tab" and other items when right click on …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_context_menu/context_menu_content_type_extension_popup.cc

Issue 763093002: Context menu in popup window is missing "Open link in new tab" and other items when right click on … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/renderer_context_menu/context_menu_content_type_extension_popup.cc

diff --git a/chrome/browser/renderer_context_menu/context_menu_content_type_extension_popup.cc b/chrome/browser/renderer_context_menu/context_menu_content_type_extension_popup.cc

index 46e61b3d6faccc009c0c7c7328f93439b6a2bc4c..f36e9ac73f335d773c0c3fe02a029c7ed65242ce 100644

--- a/chrome/browser/renderer_context_menu/context_menu_content_type_extension_popup.cc

+++ b/chrome/browser/renderer_context_menu/context_menu_content_type_extension_popup.cc

@@ -15,6 +15,7 @@ ContextMenuContentTypeExtensionPopup::~ContextMenuContentTypeExtensionPopup() {

bool ContextMenuContentTypeExtensionPopup::SupportsGroup(int group) {

switch (group) {

+ case ITEM_GROUP_LINK:

lazyboy 2014/11/27 18:44:07 I don't see any issue with this, although this was

Yoyo Zhou 2014/12/01 17:47:41 I don't know why. It seems like an oversight.

case ITEM_GROUP_EDITABLE:

case ITEM_GROUP_COPY:

case ITEM_GROUP_SEARCH_PROVIDER:

« no previous file with comments | « no previous file | no next file » | no next file with comments »