chromeos/chromeos.gyp - Issue 762633002: Use NetworkConnectionObserver to trigger connect failure notifications

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/chromeos.gyp

Issue 762633002: Use NetworkConnectionObserver to trigger connect failure notifications (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc ('k') | chromeos/network/auto_connect_handler.h » ('j') | chromeos/network/network_connection_handler.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromeos/chromeos.gyp

diff --git a/chromeos/chromeos.gyp b/chromeos/chromeos.gyp

index 485c7f6cb6fd96df16a50455429c6c0c58eff99c..46eb3077d404a4c8fcb2298b6a3b1519fefcd4b9 100644

--- a/chromeos/chromeos.gyp

+++ b/chromeos/chromeos.gyp

@@ -340,6 +340,8 @@

'network/network_configuration_observer.h',

'network/network_connection_handler.cc',

'network/network_connection_handler.h',

+ 'network/network_connection_observer.cc',

pneubeck (no reviews) 2015/01/04 16:57:00 do you have to update the BUILD.gn file too?

stevenjb 2015/01/09 18:18:02 Nope, .gn imports chromeos_sources from this file.

+ 'network/network_connection_observer.h',

'network/network_device_handler.cc',

'network/network_device_handler.h',

'network/network_device_handler_impl.cc',