chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc - Issue 762633002: Use NetworkConnectionObserver to trigger connect failure notifications

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc

Issue 762633002: Use NetworkConnectionObserver to trigger connect failure notifications (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc

diff --git a/chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc b/chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc

index ce5f031af1041fabd043e3cc005c1f0106bb0a88..27d79f67625cdc7441049f169348e0f8c08ccaa2 100644

--- a/chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc

+++ b/chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc

@@ -623,7 +623,7 @@ void InternetOptionsHandler::GetManagedPropertiesResult(

// out a more robust way to track errors. Service.Error is transient so we

// use NetworkState.error() which accurately tracks the "last" error.

dictionary->SetString(kTagErrorMessage,

- ui::NetworkConnect::Get()->GetErrorString(

+ ui::NetworkConnect::Get()->GetShillErrorString(

network->error(), service_path));

// Add additional non-ONC cellular properties to inform the UI.

if (network->type() == shill::kTypeCellular) {

« no previous file with comments | « chrome/browser/chromeos/options/wimax_config_view.cc ('k') | chromeos/chromeos.gyp » ('j') | chromeos/chromeos.gyp » ('J')