athena/system/network_selector.cc - Issue 762633002: Use NetworkConnectionObserver to trigger connect failure notifications

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: athena/system/network_selector.cc

Issue 762633002: Use NetworkConnectionObserver to trigger connect failure notifications (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: athena/system/network_selector.cc

diff --git a/athena/system/network_selector.cc b/athena/system/network_selector.cc

index 5653c3f08a21a02d595ba3bceb79ca7b6462521a..061408895294f473c3a2ea8d37f9b8eedc960508 100644

--- a/athena/system/network_selector.cc

+++ b/athena/system/network_selector.cc

@@ -262,7 +262,7 @@ class NetworkRow : public views::View {

scoped_ptr<base::DictionaryValue> error_data) {

if (error_name == NetworkConnectionHandler::kErrorConnectCanceled)

return;

- if (error_name == shill::kErrorBadPassphrase ||

+ if (error_name == NetworkConnectionHandler::kErrorBadPassphrase ||

error_name == NetworkConnectionHandler::kErrorPassphraseRequired ||

error_name == NetworkConnectionHandler::kErrorConfigurationRequired ||

error_name == NetworkConnectionHandler::kErrorAuthenticationRequired) {

« no previous file with comments | « no previous file | chrome/browser/chromeos/options/vpn_config_view.cc » ('j') | chromeos/chromeos.gyp » ('J')