Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2022)

Issue 762103002: aria-level is not exposed correctly for html header(h1...h6) tags. (Closed)

Created:
6 years ago by shreeramk
Modified:
6 years ago
Reviewers:
dmazzoni
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

aria-level is not exposed correctly for html header(h1...h6) tags. This CL will match the implementation on Firefox. Content: <h1>Level 1</h1> <h1 aria-level="2">Level 2</h1> <h3 aria-level="4">Level 4</h3> <h4 aria-level="2" role="heading">Level 2</h4> AX Tree ROLE_SYSTEM_DOCUMENT READONLY FOCUSABLE IA2_ROLE_HEADING name='Level 1' level:1 ROLE_SYSTEM_STATICTEXT name='Level 1' IA2_ROLE_HEADING name='Level 2' level:2 ROLE_SYSTEM_STATICTEXT name='Level 2' IA2_ROLE_HEADING name='Level 4' level:4 ROLE_SYSTEM_STATICTEXT name='Level 4' IA2_ROLE_HEADING name='Level 2' level:2 ROLE_SYSTEM_STATICTEXT name='Level 2' Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186200

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/modules/accessibility/AXNodeObject.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
shreeramk
Please review! Thanks :)
6 years ago (2014-11-28 08:33:50 UTC) #2
dmazzoni
lgtm Great. Please add a test for this in a follow-up change. Do you think ...
6 years ago (2014-11-29 07:44:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/762103002/1
6 years ago (2014-11-29 07:45:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=186200
6 years ago (2014-11-29 08:20:30 UTC) #6
shreeramk
On 2014/11/29 07:44:36, dmazzoni wrote: > lgtm > > Great. Please add a test for ...
6 years ago (2014-11-30 06:00:29 UTC) #7
dmazzoni
On 2014/11/30 06:00:29, shreeramk wrote: > The spec says for MSAA+ UIA: > When used ...
6 years ago (2014-12-01 06:56:01 UTC) #8
shreeramk
6 years ago (2014-12-01 06:58:03 UTC) #9
Message was sent while issue was closed.
On 2014/12/01 06:56:01, dmazzoni wrote:
> On 2014/11/30 06:00:29, shreeramk wrote:
> > The spec says for MSAA+ UIA:
> > When used on a heading, expose StyleId_Headingn where n is the heading
level.
> > UIA supports up to heading level 9.
> 
> OK, I'd like a patch that limits the heading level to 1 - 9 if you want.

Sure, I ll submit a patch to limit aria heading level.

Powered by Google App Engine
This is Rietveld 408576698