Source/modules/accessibility/AXNodeObject.cpp - Issue 762103002: aria-level is not exposed correctly for html header(h1...h6) tags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/accessibility/AXNodeObject.cpp

Issue 762103002: aria-level is not exposed correctly for html header(h1...h6) tags. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/accessibility/AXNodeObject.cpp

diff --git a/Source/modules/accessibility/AXNodeObject.cpp b/Source/modules/accessibility/AXNodeObject.cpp

index d532cb22d7305b3e8a7cbb1cc319ed858cb1a2e8..151bb67176eda090b410c3d42c3c3fd1d72b8158 100644

--- a/Source/modules/accessibility/AXNodeObject.cpp

+++ b/Source/modules/accessibility/AXNodeObject.cpp

@@ -878,7 +878,7 @@ int AXNodeObject::headingLevel() const

if (!node)

return 0;

- if (ariaRoleAttribute() == HeadingRole)

+ if (roleValue() == HeadingRole && hasAttribute(aria_levelAttr))

return getAttribute(aria_levelAttr).toInt();

if (!node->isHTMLElement())

« no previous file with comments | « no previous file | no next file » | no next file with comments »