Index: pkg/compiler/lib/src/universe/universe.dart |
diff --git a/pkg/compiler/lib/src/universe/universe.dart b/pkg/compiler/lib/src/universe/universe.dart |
index b71d020be5c2b166d4f7b235845d9562b8b6e3dd..7f2de66f642169400d77735cce361da3f8b17dae 100644 |
--- a/pkg/compiler/lib/src/universe/universe.dart |
+++ b/pkg/compiler/lib/src/universe/universe.dart |
@@ -497,34 +497,30 @@ class Selector { |
/** |
* Returns a `List` with the evaluated arguments in the normalized order. |
* |
- * [compileArgument] is a function that returns a compiled version |
- * of an argument located in [arguments]. |
- * |
floitsch
2014/11/27 15:57:27
I don't like this change.
We shouldn't compile arg
sigurdm
2014/11/28 09:24:24
They are all compiled anyways.
|
* [compileDefaultValue] is a function that returns a compiled constant |
- * of an optional argument that is not in [arguments]. |
+ * of an optional argument that is not in [compiledArguments]. |
* |
* Precondition: `this.applies(element, world)`. |
* |
* Invariant: [element] must be the implementation element. |
*/ |
/*<S, T>*/ List/*<T>*/ makeArgumentsList( |
- List/*<S>*/ arguments, |
FunctionElement element, |
- /*T*/ compileArgument(/*S*/ argument), |
+ List/*<T>*/ compiledArguments, |
/*T*/ compileDefaultValue(ParameterElement element)) { |
assert(invariant(element, element.isImplementation)); |
List/*<T>*/ result = new List(); |
FunctionSignature parameters = element.functionSignature; |
int i = 0; |
parameters.forEachRequiredParameter((ParameterElement element) { |
- result.add(compileArgument(arguments[i])); |
+ result.add(compiledArguments[i]); |
++i; |
}); |
if (!parameters.optionalParametersAreNamed) { |
parameters.forEachOptionalParameter((ParameterElement element) { |
- if (i < arguments.length) { |
- result.add(compileArgument(arguments[i])); |
+ if (i < compiledArguments.length) { |
+ result.add(compiledArguments[i]); |
++i; |
} else { |
result.add(compileDefaultValue(element)); |
@@ -533,8 +529,8 @@ class Selector { |
} else { |
// Visit named arguments and add them into a temporary list. |
List compiledNamedArguments = []; |
- for (; i < arguments.length; ++i) { |
- compiledNamedArguments.add(compileArgument(arguments[i])); |
+ for (; i < compiledArguments.length; ++i) { |
+ compiledNamedArguments.add(compiledArguments[i]); |
} |
// Iterate over the optional parameters of the signature, and try to |
// find them in [compiledNamedArguments]. If found, we use the |