Support for map literals in cps js emitter

pkg/compiler/lib/src/universe/universe.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library universe;
 
 import '../elements/elements.dart';
 import '../dart2jslib.dart';
 import '../dart_types.dart';
 import '../types/types.dart';
@@ skipping 479 matching lines @@
   }
 
   bool applies(Element element, World world) {
     if (!sameNameHack(element, world)) return false;
     return appliesUnnamed(element, world);
   }
 
   /**
    * Returns a `List` with the evaluated arguments in the normalized order.
    *
-   * [compileArgument] is a function that returns a compiled version
-   * of an argument located in [arguments].
-   *

[floitsch, 2014/11/27 15:57:27]

I don't like this change.
We shouldn't compile arguments that aren't needed.

If you can't avoid the compilation of arguments in some places, just make the
compileArgument the identity-function.

[sigurdm, 2014/11/28 09:24:24]

They are all compiled anyways.

    * [compileDefaultValue] is a function that returns a compiled constant
-   * of an optional argument that is not in [arguments].
+   * of an optional argument that is not in [compiledArguments].
    *
    * Precondition: `this.applies(element, world)`.
    *
    * Invariant: [element] must be the implementation element.
    */
   /*<S, T>*/ List/*<T>*/ makeArgumentsList(
-        List/*<S>*/ arguments,
         FunctionElement element,
-        /*T*/ compileArgument(/*S*/ argument),
+        List/*<T>*/ compiledArguments,
         /*T*/ compileDefaultValue(ParameterElement element)) {
     assert(invariant(element, element.isImplementation));
     List/*<T>*/ result = new List();
     FunctionSignature parameters = element.functionSignature;
     int i = 0;
     parameters.forEachRequiredParameter((ParameterElement element) {
-      result.add(compileArgument(arguments[i]));
+      result.add(compiledArguments[i]);
       ++i;
     });
 
     if (!parameters.optionalParametersAreNamed) {
       parameters.forEachOptionalParameter((ParameterElement element) {
-        if (i < arguments.length) {
-          result.add(compileArgument(arguments[i]));
+        if (i < compiledArguments.length) {
+          result.add(compiledArguments[i]);
           ++i;
         } else {
           result.add(compileDefaultValue(element));
         }
       });
     } else {
       // Visit named arguments and add them into a temporary list.
       List compiledNamedArguments = [];
-      for (; i < arguments.length; ++i) {
-        compiledNamedArguments.add(compileArgument(arguments[i]));
+      for (; i < compiledArguments.length; ++i) {
+        compiledNamedArguments.add(compiledArguments[i]);
       }
       // Iterate over the optional parameters of the signature, and try to
       // find them in [compiledNamedArguments]. If found, we use the
       // value in the temporary list, otherwise the default value.
       parameters.orderedOptionalParameters
           .forEach((ParameterElement element) {
         int foundIndex = namedArguments.indexOf(element.name);
         if (foundIndex != -1) {
           result.add(compiledNamedArguments[foundIndex]);
         } else {
@@ skipping 302 matching lines @@
 
   Selector extendIfReachesAll(Compiler compiler) {
     bool canReachAll = compiler.enabledInvokeOn
         && mask.needsNoSuchMethodHandling(this, compiler.world);
     return canReachAll
         ? new TypedSelector(
             compiler.typesTask.dynamicType, this, compiler.world)
         : this;
   }
 }