Do not call GenerateCacheKey() if disk cache is disabled.

Do not call GenerateCacheKey() if disk cache is disabled.

BUG=

Committed: https://crrev.com/447b8b18c9104a9be7ca95a7ccc346bf2f0c985d
Cr-Commit-Position: refs/heads/master@{#307213}

[stinae, 2014-12-03 09:00:02]

stinae@opera.com changed reviewers:
+ rdsmith@chromium.org

[stinae, 2014-12-03 10:16:09]

@rdsmith: Do you think this is a proper way to avoid hitting the DCHECK in
GenerateCacheKey() after disabling the disk cache?

[Randy Smith (Not in Mondays), 2014-12-03 16:43:57]

rdsmith@chromium.org changed reviewers:
+ rvargas@chromium.org

[Randy Smith (Not in Mondays), 2014-12-03 16:43:58]

I'm the wrong person for cache questions; Ricardo is far more likely to know the
answer off the top of his head than I.  Ricardo?

[Randy Smith (Not in Mondays), 2014-12-03 16:44:16]

rdsmith@chromium.org changed reviewers:
- rdsmith@chromium.org

[rvargas (doing something else), 2014-12-04 02:35:14]

sure

https://codereview.chromium.org/761763003/diff/1/net/http/http_cache.cc
File net/http/http_cache.cc (right):

https://codereview.chromium.org/761763003/diff/1/net/http/http_cache.cc#newco...
net/http/http_cache.cc:808: if (!disk_cache_ || mode_ == DISABLE)
This one should not be needed. (it is already covered by the only caller)

[stinae, 2014-12-05 14:53:58]

On 2014/12/04 02:35:14, rvargas wrote:
> sure
> 
> https://codereview.chromium.org/761763003/diff/1/net/http/http_cache.cc
> File net/http/http_cache.cc (right):
> 
>
https://codereview.chromium.org/761763003/diff/1/net/http/http_cache.cc#newco...
> net/http/http_cache.cc:808: if (!disk_cache_ || mode_ == DISABLE)
> This one should not be needed. (it is already covered by the only caller)

@rvargas: Yes, I think the check in HttpCache::DoomMainEntryForUrl() is no
longer needed. I have updated the patch now.

[rvargas (doing something else), 2014-12-05 20:27:26]

lgtm

[stinae, 2014-12-08 07:31:00]

The CQ bit was checked by stinae@opera.com

[commit-bot: I haz the power, 2014-12-08 07:31:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/761763003/20001

[commit-bot: I haz the power, 2014-12-08 10:41:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-12-08 10:42:44]

Patchset 2 (id:??) landed as
https://crrev.com/447b8b18c9104a9be7ca95a7ccc346bf2f0c985d
Cr-Commit-Position: refs/heads/master@{#307213}